Skip to content

Conversation

devmotion
Copy link
Member

This should be hidden in stdlib/distributions.jl and at most be defined in DynamicPPL (see TuringLang/DynamicPPL.jl#414 (comment)). I wonder, are they used anywhere and what breaks if we remove them completely?

Copy link
Member

@torfjelde torfjelde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy to merge if tests pass:)

@devmotion
Copy link
Member Author

Seems to be the case 🙂 I'll bump the version and merge once all tests pass successfully.

@codecov
Copy link

codecov bot commented Jun 30, 2022

Codecov Report

Merging #1849 (a98e047) into master (9f482f3) will increase coverage by 0.13%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1849      +/-   ##
==========================================
+ Coverage   80.89%   81.03%   +0.13%     
==========================================
  Files          24       24              
  Lines        1471     1466       -5     
==========================================
- Hits         1190     1188       -2     
+ Misses        281      278       -3     
Impacted Files Coverage Δ
src/stdlib/distributions.jl 57.95% <ø> (+0.96%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9f482f3...a98e047. Read the comment docs.

@coveralls
Copy link

coveralls commented Jun 30, 2022

Pull Request Test Coverage Report for Build 2590200632

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.1%) to 81.037%

Totals Coverage Status
Change from base Build 2581526775: 0.1%
Covered Lines: 1188
Relevant Lines: 1466

💛 - Coveralls

@devmotion devmotion merged commit 499f295 into master Jun 30, 2022
@delete-merged-branch delete-merged-branch bot deleted the dw/nodist branch June 30, 2022 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants