Skip to content

[breaking] v0.40.0 #2587

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Aug 12, 2025
Merged

[breaking] v0.40.0 #2587

merged 9 commits into from
Aug 12, 2025

Conversation

penelopeysm
Copy link
Member

@penelopeysm penelopeysm commented Jun 6, 2025

Merge breaking changes into here.

@penelopeysm penelopeysm marked this pull request as draft June 6, 2025 18:45
Copy link
Contributor

Turing.jl documentation for PR #2587 is available at:
https://TuringLang.github.io/Turing.jl/previews/PR2587/

Copy link

codecov bot commented Jul 19, 2025

Codecov Report

❌ Patch coverage is 93.93939% with 14 lines in your changes missing coverage. Please review.
✅ Project coverage is 85.70%. Comparing base (d75e6f2) to head (f137481).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/mcmc/particle_mcmc.jl 88.63% 10 Missing ⚠️
src/mcmc/Inference.jl 91.30% 2 Missing ⚠️
src/mcmc/gibbs.jl 91.30% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2587      +/-   ##
==========================================
+ Coverage   84.88%   85.70%   +0.82%     
==========================================
  Files          22       22              
  Lines        1475     1434      -41     
==========================================
- Hits         1252     1229      -23     
+ Misses        223      205      -18     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@coveralls
Copy link

coveralls commented Jul 19, 2025

Pull Request Test Coverage Report for Build 16911385102

Details

  • 206 of 229 (89.96%) changed or added relevant lines in 16 files are covered.
  • 25 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-1.4%) to 83.566%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/mcmc/Inference.jl 21 23 91.3%
src/mcmc/gibbs.jl 21 23 91.3%
src/mcmc/particle_mcmc.jl 78 87 89.66%
src/mcmc/ess.jl 0 10 0.0%
Files with Coverage Reduction New Missed Lines %
src/mcmc/hmc.jl 2 93.65%
src/mcmc/ess.jl 23 0.0%
Totals Coverage Status
Change from base Build 16800936663: -1.4%
Covered Lines: 1195
Relevant Lines: 1430

💛 - Coveralls

penelopeysm and others added 6 commits July 21, 2025 14:58
* First efforts towards DPPL 0.37 compat, WIP

* More DPPL 0.37 compat work, WIP

* Add [sources] for [email protected]

* Remove context argument from `LogDensityFunction`

* Fix MH

* Remove spurious logging

* Remove residual OptimizationContext

* Delete files that were removed in previous releases

* Fix typo

* Simplify ESS

* Fix LDF

* Fix Prior(), fix a couple more imports

* fixes

* actually fix prior

* Remove extra return value from tilde_assume

* fix ldf

* actually fix prior

* fix HMC log-density

* fix ldf

* fix make_evaluate_...

* more fixes for evaluate!!

* fix hmc

* fix run_ad

* even more fixes (oh goodness when will this end)

* more fixes

* fix

* more fix fix fix

* fix return values of tilde pipeline

* even more fixes

* Fix missing import

* More MH fixes

* Fix conversion

* don't think it really needs those type params

* implement copy for LogPriorWithoutJacAcc

* Even more fixes

* More fixes; I think the remaining failures are pMCMC related

* Fix merge

* DPPL 0.37 compat for particle MCMC (#2625)

* Progress in DPPL 0.37 compat for particle MCMC

* WIP PMCMC work

* Gibbs fixes for DPPL 0.37 (plus tiny bugfixes for ESS + HMC) (#2628)

* Obviously this single commit will make Gibbs work

* Fixes for ESS

* Fix HMC call

* improve some comments

* Fixes to ProduceLogLikelihoodAccumulator

* Use LogProbAccumulator for ProduceLogLikelihoodAccumulator

* use get_conditioned_gibbs

---------

Co-authored-by: Penelope Yong <[email protected]>

* "Fixes" for PG-in-Gibbs (#2629)

* WIP PMCMC work

* Fixes to ProduceLogLikelihoodAccumulator

* inline definition of `set_retained_vns_del!`

* Fix ProduceLogLikelihoodAcc

* Remove all uses of `set_retained_vns_del!`

* Use nice functions

* Remove PG tests with dynamic number of Gibbs-conditioned-observations

* Fix essential/container tests

* Update pMCMC implementation as per discussion

* remove extra printing statements

* revert unneeded changes

* Add back (some kind of) dynamic model test

* fix rebase

* Add a todo comment for dynamic model tests

---------

Co-authored-by: Markus Hauru <[email protected]>

* Use accumulators to fix all logp calculations when sampling (#2630)

* Use new `getlogjoint` for optimisation

* Change getlogjoint -> getlogjoint_internal where needed

* Enforce re-evaluation when constructing `Transition`

* fix tests

* Remove extra evaluations from SGLD and SGHMC

* Remove dead `transitions_from_chain` method (used to be part of `predict`)

* metadata -> getstats_with_lp

* Clean up some stray getlogp

* InitContext isn't for 0.37, update comments

* Fix merge

* Do not re-evaluate model for Prior (#2644)

* Allow Prior to skip model re-evaluation

* remove unneeded `default_chain_type` method

* add a test

* add a likelihood term too

* why not test correctness while we're at it

* No need to test AD for SamplingContext{<:HMC} (#2645)

* change breaking -> main

* Remove calls to resetlogp!! & add changelog (#2650)

* Remove calls to resetlogp!!

* Add a changelog for 0.40

* Update HISTORY.md

Co-authored-by: Markus Hauru <[email protected]>

---------

Co-authored-by: Markus Hauru <[email protected]>

* Remove `[sources]`

* Unify Turing `Transition`s, fix some tests (#2651)

* Unify `Transition` methods

* Add tests

* Add same test for SGLD/SGHMC

* Refactor so that it's nice and organised

* Fix failing test on 1.10

* just increase the atol

* Make addlogprob test more robust

* Remove stray `@show`

Co-authored-by: Markus Hauru <[email protected]>

---------

Co-authored-by: Markus Hauru <[email protected]>

* Update changelog for PG in Gibbs

---------

Co-authored-by: Penelope Yong <[email protected]>
@penelopeysm penelopeysm marked this pull request as ready for review August 12, 2025 14:47
@penelopeysm
Copy link
Member Author

CI failures are all unrelated to Turing (either Libtask 1.12, coverage provider server fail, or SciML/RecursiveArrayTools.jl#477), so will merge.

@penelopeysm penelopeysm merged commit 2a6e067 into main Aug 12, 2025
26 of 33 checks passed
@penelopeysm penelopeysm deleted the breaking branch August 12, 2025 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants