Skip to content

Unify Turing Transitions, fix some tests #2651

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Aug 12, 2025
Merged

Unify Turing Transitions, fix some tests #2651

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
3776489
Unify `Transition` methods
penelopeysm Aug 11, 2025
ef18491
Add tests
penelopeysm Aug 11, 2025
cb903ae
Add same test for SGLD/SGHMC
penelopeysm Aug 11, 2025
fb3660e
Refactor so that it's nice and organised
penelopeysm Aug 11, 2025
0f65433
Fix failing test on 1.10
penelopeysm Aug 11, 2025
62f3bce
just increase the atol
penelopeysm Aug 11, 2025
0e54e59
Make addlogprob test more robust
penelopeysm Aug 12, 2025
7915287
Remove stray `@show`
penelopeysm Aug 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions test/mcmc/particle_mcmc.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,16 +133,17 @@ end
@model function addlogprob_demo()
x ~ Normal(0, 1)
if x < 0
@addlogprob! -2.0
@addlogprob! -10.0
else
# Need a balanced number of addlogprobs in all branches, or
# else PG will error
@addlogprob! 0.0
end
end
c = sample(addlogprob_demo(), PG(10), 100)
c = sample(StableRNG(468), addlogprob_demo(), PG(10), 100)
@show mean(c[:x])
# Result should be biased towards x > 0.
@test mean(c[:x]) > 0.5
@test mean(c[:x]) > 0.7
end

# https://github.com/TuringLang/Turing.jl/issues/2007
Expand Down
Loading