Skip to content

Conversation

@penelopeysm
Copy link
Member

Terrifyingly, Turing overloaded an internal DynamicPPL function, get_matching_type. The function was renamed in a patch release, which is semver compliant. However, that makes Turing error when loaded, because there is no longer such a function to overload. This PR removes the overload (it was dead code and not accomplishing anything anyway).

@penelopeysm penelopeysm merged commit 2b95583 into main Jan 7, 2026
28 checks passed
@penelopeysm penelopeysm deleted the py/match branch January 7, 2026 20:38
@github-actions
Copy link
Contributor

github-actions bot commented Jan 7, 2026

Turing.jl documentation for PR #2748 is available at:
https://TuringLang.github.io/Turing.jl/previews/PR2748/

@codecov
Copy link

codecov bot commented Jan 7, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.65%. Comparing base (969f39a) to head (b35bf9c).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2748      +/-   ##
==========================================
+ Coverage   86.51%   86.65%   +0.13%     
==========================================
  Files          20       20              
  Lines        1261     1259       -2     
==========================================
  Hits         1091     1091              
+ Misses        170      168       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mhauru
Copy link
Member

mhauru commented Jan 8, 2026

Gee, thanks for catching this quickly, that was nasty.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants