Fix off-by-one NUTS adaptations #2751
Merged
+7
−3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2750.
Prior to #2674 the counter
iwould be initialised to1after the first adaptation had happened. That PR, first released in v0.41, changed it such that the counteriwas initialised to1before the first adaptation happened. That should, of course, be zero, which this PR fixes.I've checked locally and this change makes it such that results from pre-v0.41 are exactly reproducible now, as long as all else is equal (e.g. initialisation, discard_initial, etc).