Skip to content

Conversation

@penelopeysm
Copy link
Member

@penelopeysm penelopeysm commented Jan 25, 2026

The usual game of trying to see if DPPL breaks anything upstream.

(20 minutes later)

Okay, maybe 'if DPPL breaks anything upstream' was a bit optimistic. More like seeing what DPPL broke upstream.

@penelopeysm
Copy link
Member Author

penelopeysm commented Jan 25, 2026

Ok, MH is totally borked. I refrain from using a stronger word. It basically needs to be rewritten. I'd say though, that InitContext actually gives us a really good way of doing this.

@github-actions
Copy link
Contributor

Turing.jl documentation for PR #2756 is available at:
https://TuringLang.github.io/Turing.jl/previews/PR2756/

@codecov
Copy link

codecov bot commented Jan 25, 2026

Codecov Report

❌ Patch coverage is 43.81443% with 109 lines in your changes missing coverage. Please review.
✅ Project coverage is 43.12%. Comparing base (2eb47a0) to head (3718d77).

Files with missing lines Patch % Lines
src/mcmc/mh.jl 38.20% 55 Missing ⚠️
src/mcmc/gibbs_conditional.jl 0.00% 20 Missing ⚠️
src/mcmc/abstractmcmc.jl 7.14% 13 Missing ⚠️
src/mcmc/gibbs.jl 62.06% 11 Missing ⚠️
src/mcmc/particle_mcmc.jl 50.00% 2 Missing ⚠️
src/optimisation/Optimisation.jl 0.00% 2 Missing ⚠️
src/optimisation/init.jl 60.00% 2 Missing ⚠️
src/variational/Variational.jl 0.00% 2 Missing ⚠️
src/mcmc/ess.jl 95.23% 1 Missing ⚠️
src/mcmc/external_sampler.jl 0.00% 1 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (2eb47a0) and HEAD (3718d77). Click for more details.

HEAD has 16 uploads less than BASE
Flag BASE (2eb47a0) HEAD (3718d77)
24 8
Additional details and impacted files
@@              Coverage Diff              @@
##           breaking    #2756       +/-   ##
=============================================
- Coverage     85.31%   43.12%   -42.20%     
=============================================
  Files            23       22        -1     
  Lines          1430     1389       -41     
=============================================
- Hits           1220      599      -621     
- Misses          210      790      +580     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

penelopeysm added a commit to TuringLang/DynamicPPL.jl that referenced this pull request Jan 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants