-
Notifications
You must be signed in to change notification settings - Fork 8
bump versions, update AD tests, update workflows #166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
b59ab17
bump test ForwardDiff -> 1
penelopeysm a13bc6e
bump Turing to include 0.38, 0.39
penelopeysm 2a037c1
replace Tracker / Zygote with Mooncake
penelopeysm f305264
bump patch
penelopeysm 630bc6e
use turinglang/actions/format
penelopeysm 96a0e1b
fix CI workflow (macOS doesn't use x86)
penelopeysm bd03def
fix concurrency behaviour on CI
penelopeysm 2d5eac5
min -> lts since this doesn't have a min
penelopeysm a538257
fix syntax
penelopeysm 69c726a
imports
penelopeysm ce483e4
Update test/ad_backends.jl
penelopeysm fac5c4a
Bump minor version
penelopeysm 2ae3417
enable coverage
penelopeysm b7e5ffb
Re-add coverage badges
penelopeysm File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,7 +1,7 @@ | ||
name = "TuringGLM" | ||
uuid = "0004c1f4-53c5-4d43-a221-a1dac6cf6b74" | ||
authors = ["Jose Storopoli <[email protected]>", "Rik Huijzer <[email protected]>", "contributors"] | ||
version = "2.13.0" | ||
version = "2.14.0" | ||
|
||
[deps] | ||
Distributions = "31c24e10-a181-5473-b8eb-7969acd0382f" | ||
|
@@ -29,5 +29,5 @@ StatsBase = "0.33 - 0.34" | |
StatsModels = "0.6.28 - 0.7" | ||
TableOperations = "1.2" | ||
Tables = "1.6" | ||
Turing = "0.20 - 0.37" | ||
Turing = "0.20 - 0.39" | ||
julia = "1" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,28 +1,20 @@ | ||
@timed_testset "ad_backends" begin | ||
using ForwardDiff: ForwardDiff | ||
using ReverseDiff: ReverseDiff | ||
using Mooncake: Mooncake | ||
|
||
@timed_testset "ad_backends.jl" begin | ||
DATA_DIR = joinpath("..", "data") | ||
cheese = CSV.read(joinpath(DATA_DIR, "cheese.csv"), DataFrame) | ||
f = @formula(y ~ (1 | cheese) + background) | ||
m = turing_model(f, cheese) | ||
# only running 2 samples to test if the different ADs runs | ||
@timed_testset "ForwardDiff" begin | ||
chn = sample(m, NUTS(; adtype=AutoForwardDiff(; chunksize=8)), 2) | ||
@test chn isa Chains | ||
end | ||
# TODO: fix Tracker tests | ||
# @timed_testset "Tracker" begin | ||
# using Tracker | ||
# chn = sample(m, NUTS(; adtype=AutoTracker()), 2) | ||
# @test chn isa Chains | ||
# end | ||
# TODO: fix Zygote tests | ||
# @timed_testset "Zygote" begin | ||
# using Zygote | ||
# chn = sample(m, NUTS(; adtype=AutoZygote()), 2) | ||
# @test chn isa Chains | ||
# end | ||
@timed_testset "ReverseDiff" begin | ||
using ReverseDiff | ||
chn = sample(m, NUTS(; adtype=AutoReverseDiff(; compile=true)), 2) | ||
@test chn isa Chains | ||
|
||
ADTYPES = [ | ||
AutoForwardDiff(), | ||
AutoReverseDiff(; compile=false), | ||
AutoReverseDiff(; compile=true), | ||
AutoMooncake(; config=nothing), | ||
] | ||
@testset "$adtype" for adtype in ADTYPES | ||
@test sample(m, NUTS(; adtype=adtype), 20) isa Chains | ||
end | ||
end |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is '1.10' covered by '1'?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh LTS is 1.10 and
1
is1.11
gotcha.