Conversation
|
@lenisko is attempting to deploy a commit to the turtiesocks' projects Team on Vercel. A member of the Team first needs to authorize it. |
|
Not really sure how koji works in this regard or exactly what your PR does -- but a fort route would likely include pokestops, gyms and stations - I'm not sure you would want to map them seperately. Although it might make sense to show them on the map in a different way. |
TurtIeSocks
left a comment
TurtIeSocks
left a comment
There was a problem hiding this comment.
Seems mostly fine, just a couple of small comments.
| Type::CirclePokemon | Type::CircleSmartPokemon => self.pokemon_mode_route, | ||
| Type::CircleRaid | Type::CircleSmartRaid => self.fort_mode_route, | ||
| Type::CircleQuest => self.quest_mode_route, | ||
| Type::CircleStation | Type::CircleSmartStation => self.fort_mode_route, |
There was a problem hiding this comment.
Does this mean that stations will be included a fort plan? If so, then yes it's likely correct
| #[sea_orm(string_value = "circle_station")] | ||
| CircleStation, | ||
| #[sea_orm(string_value = "circle_smart_station")] | ||
| CircleSmartStation, |
There was a problem hiding this comment.
do we need CircleSmartStation? does rdm use it?
There was a problem hiding this comment.
No clue! Copy-pasted pokemon.
There was a problem hiding this comment.
RDM db doesn't even support station :)
| 'circle_smart_pokemon', | ||
| 'circle_raid', | ||
| 'circle_smart_raid', | ||
| 'circle_station', |
There was a problem hiding this comment.
I think this can be completely removed for RDM, RDM does not have stations in DB
4 participants
It's working, but would be great to take a peak at queries (if I didn't miss anything).