fix: Lightbox 커서 개선 및 Mermaid 이미지 클릭 활성화#88
Merged
Twodragon0 merged 1 commit intomainfrom Mar 7, 2026
Merged
Conversation
- Mermaid SVG 이미지도 lightbox로 확대 가능하도록 변경 - 기본 커서를 grab에서 zoom-in으로 변경 - 확대 시에만 grab/grabbing 커서 표시
|
Deployment failed with the following error: Learn More: https://vercel.com/twodragon0s-projects?upgradeToPro=build-rate-limit |
There was a problem hiding this comment.
Pull request overview
This PR improves the lightbox UX by changing cursor behavior and enabling mermaid diagram images to open in the lightbox. Previously, mermaid SVG images were explicitly excluded from lightbox attachment, and the lightbox used a grab cursor in its default (non-zoomed) state.
Changes:
- Removed the early-return guard that skipped mermaid SVG images (
/mermaid/path check), allowing them to be clicked to open in the lightbox - Changed the default lightbox image cursor from
grabtozoom-inand the zoomed cursor frommovetograb, creating a more intuitive cursor progression
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
assets/js/post-page.js |
Removed the mermaid image skip filter in attachImageHandlers() |
_sass/_lightbox.scss |
Updated cursor values: default grab → zoom-in, zoomed move → grab |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
grab에서zoom-in으로 변경 (손바닥 모양 제거)grab/grabbing커서 표시Test plan