Skip to content

fix: Lightbox 커서 개선 및 Mermaid 이미지 클릭 활성화#88

Merged
Twodragon0 merged 1 commit intomainfrom
fix/lightbox-cursor-mermaid-click
Mar 7, 2026
Merged

fix: Lightbox 커서 개선 및 Mermaid 이미지 클릭 활성화#88
Twodragon0 merged 1 commit intomainfrom
fix/lightbox-cursor-mermaid-click

Conversation

@Twodragon0
Copy link
Owner

Summary

  • Mermaid SVG 이미지도 클릭하여 lightbox로 확대 가능하도록 변경
  • 기본 lightbox 커서를 grab에서 zoom-in으로 변경 (손바닥 모양 제거)
  • 확대(zoom) 시에만 grab/grabbing 커서 표시

Test plan

  • Mermaid 이미지 클릭 시 lightbox 열림 확인
  • lightbox에서 기본 커서가 zoom-in인지 확인
  • 확대 후에만 grab 커서 표시되는지 확인

- Mermaid SVG 이미지도 lightbox로 확대 가능하도록 변경
- 기본 커서를 grab에서 zoom-in으로 변경
- 확대 시에만 grab/grabbing 커서 표시
Copilot AI review requested due to automatic review settings March 7, 2026 12:23
@vercel
Copy link

vercel bot commented Mar 7, 2026

Deployment failed with the following error:

Resource is limited - try again in 15 hours (more than 100, code: "api-deployments-free-per-day").

Learn More: https://vercel.com/twodragon0s-projects?upgradeToPro=build-rate-limit

@Twodragon0 Twodragon0 merged commit d103c53 into main Mar 7, 2026
6 of 7 checks passed
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR improves the lightbox UX by changing cursor behavior and enabling mermaid diagram images to open in the lightbox. Previously, mermaid SVG images were explicitly excluded from lightbox attachment, and the lightbox used a grab cursor in its default (non-zoomed) state.

Changes:

  • Removed the early-return guard that skipped mermaid SVG images (/mermaid/ path check), allowing them to be clicked to open in the lightbox
  • Changed the default lightbox image cursor from grab to zoom-in and the zoomed cursor from move to grab, creating a more intuitive cursor progression

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
assets/js/post-page.js Removed the mermaid image skip filter in attachImageHandlers()
_sass/_lightbox.scss Updated cursor values: default grabzoom-in, zoomed movegrab

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@Twodragon0 Twodragon0 deleted the fix/lightbox-cursor-mermaid-click branch March 9, 2026 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants