-
Notifications
You must be signed in to change notification settings - Fork 5
[DX-2178] docs: clarify Redis Sentinel with master password configuration #1124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…tion Add documentation explaining that when using Redis Sentinel with a password-protected master Redis instance, both the sentinel_password and the master password must be configured. Includes: - New section "Configuring Both Sentinel and Master Redis Passwords" - Warning about common misconfiguration - Complete configuration examples for Gateway, Dashboard, and Pump - Environment variable reference tables for each component 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
Pump Configuration Example (with both passwords)"analytics_storage_config": {
"type": "redis",
"addrs": [
"sentinel1:26379",
"sentinel2:26379",
"sentinel3:26379"
],
"master_name": "mymaster",
"sentinel_password": "your-sentinel-password",
"username": "",
"password": "your-master-redis-password",
"database": 0,
"optimisation_max_idle": 100,
"use_ssl": false
}
Dashboard Configuration Example (with both passwords)"redis_addrs": [
"sentinel1:26379",
"sentinel2:26379",
"sentinel3:26379"
],
"redis_master_name": "mymaster",
"redis_sentinel_password": "your-sentinel-password",
"redis_password": "your-master-redis-password"
Pump Configuration Example (with both passwords)"analytics_storage_config": {
"type": "redis",
"addrs": [
"sentinel1:26379",
"sentinel2:26379",
"sentinel3:26379"
],
"master_name": "mymaster",
"sentinel_password": "your-sentinel-password",
"username": "",
"password": "your-master-redis-password",
"database": 0,
"optimisation_max_idle": 100,
"use_ssl": false
}
Dashboard Configuration Example (with both passwords)"redis_addrs": [
"sentinel1:26379",
"sentinel2:26379",
"sentinel3:26379"
],
"redis_master_name": "mymaster",
"redis_sentinel_password": "your-sentinel-password",
"redis_password": "your-master-redis-password"
Pump Configuration Example (with both passwords)"analytics_storage_config": {
"type": "redis",
"addrs": [
"sentinel1:26379",
"sentinel2:26379",
"sentinel3:26379"
],
"master_name": "mymaster",
"sentinel_password": "your-sentinel-password",
"username": "",
"password": "your-master-redis-password",
"database": 0,
"optimisation_max_idle": 100,
"use_ssl": false
}
|
PR Code Suggestions ✨Explore these optional code suggestions:
|
User description
Summary
sentinel_passwordand the masterpasswordmust be configuredRelated
Test plan
🤖 Generated with Claude Code
PR Type
Documentation
Description
Add section on dual-password Sentinel setups
Provide Gateway, Dashboard, Pump examples
Include env var reference tables
Add warning about common misconfiguration
Diagram Walkthrough
File Walkthrough
redis-cluster-sentinel.mdx
Document dual-password Redis Sentinel configurationtyk-configuration-reference/redis-cluster-sentinel.mdx