extend default config and fix scrolling#143
Open
achimmihca wants to merge 3 commits intoTylemagne:masterfrom
Open
extend default config and fix scrolling#143achimmihca wants to merge 3 commits intoTylemagne:masterfrom
achimmihca wants to merge 3 commits intoTylemagne:masterfrom
Conversation
- apply getDelta before any calculation is done
- otherwise some calculations could be done with wrong value
- pass magnitude to getMult instead of lengthsq
- magnitude calculation can be simpler for scrolling because dimensions (X and Y) are handled independently (in this case magnitude is abs(deltaValue))
This was referenced Jan 23, 2021
Open
connordear
added a commit
to opus-control/Gopher360
that referenced
this pull request
Aug 12, 2021
|
Really think this should be merged. Also, if you know of any other program or tool which do a better job than this. Let me know! |
Author
I created a fork and a build that includes the changes of this PR: https://github.com/achimmihca/Gopher360/releases/tag/v1.0-achimmihca-fork |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.