Full code Cleanup

Author: Meyn

Tubifarry/Blocklisting/BaseBlocklist.cs

@@ -31,4 +31,4 @@ public abstract class BaseBlocklist<TProtocol>(IBlocklistRepository blocklistRep
 
         private static bool SameRelease(Blocklist item, ReleaseInfo release) => release.Guid.IsNotNullOrWhiteSpace() ? release.Guid.Equals(item.TorrentInfoHash) : item.Indexer.Equals(release.Indexer, StringComparison.InvariantCultureIgnoreCase);
     }
-}
+}

Tubifarry/Blocklisting/Blocklists.cs

@@ -8,4 +8,4 @@ public class YoutubeBlocklist(IBlocklistRepository blocklistRepository) : BaseBl
 
     public class SoulseekBlocklist(IBlocklistRepository blocklistRepository) : BaseBlocklist<SoulseekDownloadProtocol>(blocklistRepository)
     { }
-}
+}

Tubifarry/Core/Model/AlbumData.cs

@@ -17,6 +17,7 @@ public partial class AlbumData(string name, string downloadProtocol)
 
         // Properties from AlbumInfo
         public string AlbumName { get; set; } = string.Empty;
+
         public string ArtistName { get; set; } = string.Empty;
         public string InfoUrl { get; set; } = string.Empty;
         public string ReleaseDate { get; set; } = string.Empty;
@@ -29,11 +30,13 @@ public partial class AlbumData(string name, string downloadProtocol)
 
         // Properties from YoutubeSearchResults
         public int Bitrate { get; set; }
+
         public int BitDepth { get; set; }
         public long Duration { get; set; }
 
         // Soulseek
         public long? Size { get; set; }
+
         public int Priotity { get; set; }
         public List<string>? ExtraInfo { get; set; }
 
@@ -126,6 +129,7 @@ private static string NormalizeAlbumName(string albumName)
 
         [GeneratedRegex(@"(?i)\b(feat\.|ft\.|featuring)\b", RegexOptions.IgnoreCase, "de-DE")]
         private static partial Regex FeatRegex();
+
         [GeneratedRegex(@"\((?!feat\.)[^)]*\)")]
         private static partial Regex FeatReplaceRegex();
     }

Tubifarry/Core/Model/ApiCircuitBreaker.cs

@@ -6,8 +6,11 @@ namespace Tubifarry.Core.Model
     public interface ICircuitBreaker
     {
         bool IsOpen { get; }
+
         void RecordSuccess();
+
         void RecordFailure();
+
         void Reset();
     }
 

Tubifarry/Core/Model/AudioMetadataHandler.cs

@@ -100,11 +100,10 @@ public AudioMetadataHandler(string originalPath)
             "-movflags +faststart"
         ];
 
-
         private static readonly string[] VideoFormats =
         [
             "matroska", "webm",           // Matroska/WebM containers
-            "mov", "mp4", "m4a",          // QuickTime/MP4 containers  
+            "mov", "mp4", "m4a",          // QuickTime/MP4 containers
             "avi",                        // AVI containers
             "asf", "wmv", "wma",          // Windows Media containers
             "flv", "f4v",                 // Flash containers
@@ -209,7 +208,6 @@ public async Task<bool> TryExtractAudioFromVideoAsync()
             if (!isVideo)
                 return await EnsureFileExtAsync();
 
-
             _logger?.Trace($"Extracting audio from video file: {Path.GetFileName(TrackPath)}");
 
             try
@@ -416,7 +414,6 @@ public bool TryEmbedMetadata(Album albumInfo, Track trackInfo)
         /// <returns>True if the format can be used as a conversion target, false otherwise</returns>
         public static bool IsTargetFormatSupportedForEncoding(AudioFormat format) => BaseConversionParameters.ContainsKey(format);
 
-
         ///// <summary>
         ///// Checks if a given audio format supports embedded metadata tags.
         ///// </summary>

Tubifarry/Core/Model/FileCache.cs

@@ -136,7 +136,6 @@ public void CheckDirectory()
                 throw new InvalidOperationException($"Cache directory validation failed: {ex.Message}", ex);
             }
         }
-
     }
 
     public class CachedData<T>
@@ -145,4 +144,4 @@ public class CachedData<T>
         public DateTime CreatedAt { get; set; }
         public TimeSpan ExpirationDuration { get; set; }
     }
-}
+}

Tubifarry/Core/Model/TrustedSessionException.cs

@@ -5,9 +5,15 @@
     /// </summary>
     public class TrustedSessionException : Exception
     {
-        public TrustedSessionException(string message) : base(message) { }
-        public TrustedSessionException(string message, Exception innerException) : base(message, innerException) { }
-        public TrustedSessionException() { }
-    }
+        public TrustedSessionException(string message) : base(message)
+        {
+        }
+
+        public TrustedSessionException(string message, Exception innerException) : base(message, innerException)
+        {
+        }
 
-}
+        public TrustedSessionException()
+        { }
+    }
+}

Tubifarry/Core/Records/Lyric.cs

@@ -58,4 +58,4 @@ public static List<SyncLine> ParseSyncedLyrics(string syncedLyrics)
         [GeneratedRegex("\\[(\\d{2}:\\d{2}\\.\\d{2})\\](.*)")]
         private static partial Regex TagRegex();
     }
-}
+}

Tubifarry/Core/Records/MusicBrainzData.cs

@@ -21,8 +21,8 @@ public record MusicBrainzAlbumItem(string? AlbumId, string? Title, string? Type,
             if (releaseGroup == null)
                 return null;
 
-            var secondaryTypes = new List<string>();
-            var secondaryTypeList = releaseGroup.Element(ns + "secondary-type-list");
+            List<string> secondaryTypes = new();
+            XElement? secondaryTypeList = releaseGroup.Element(ns + "secondary-type-list");
             if (secondaryTypeList != null)
             {
                 secondaryTypes = secondaryTypeList.Elements(ns + "secondary-type")
@@ -42,4 +42,4 @@ public record MusicBrainzAlbumItem(string? AlbumId, string? Title, string? Type,
                 DateTime.TryParse(releaseGroup.Element(ns + "first-release-date")?.Value, out DateTime date) ? date : DateTime.MinValue);
         }
     }
-}
+}

Tubifarry/Core/Records/YouTubeSession.cs

@@ -76,5 +76,4 @@ private static bool CookiesAreEquivalent(Cookie[]? cookies1, Cookie[]? cookies2)
                 pair.First.Value == pair.Second.Value);
         }
     }
-
-}
+}