Fix AC charger switch state by using numeric system state values #284
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The AC charger system state is stored internally as a numeric enum value, not a mapped string.
The previous switch logic compared the state against string values
("Initializing", "Fault", etc.), which caused the switch to never
correctly reflect the charger state.
This change updates is_on_fn to rely on the numeric system state values reported by the charger. Currently treating states 3, 4, and 5 as ON.
This aligns the AC charger switch behavior with how other switches
(e.g. plant_start_stop) determine their state.
Owner
|
Great! |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The AC charger system state is stored internally as a numeric enum value, not a mapped string.
The previous switch logic compared the state against string values ("Initializing", "Fault", etc.), which caused the switch to never correctly reflect the charger state.
This change updates is_on_fn to rely on the numeric system state values reported by the charger. Currently treating states 3, 4, and 5 as ON.
This aligns the AC charger switch behavior with how other switches (e.g. plant_start_stop) determine their state.
Verified to work correctly after Modbus refresh on Home Assistant with a Sigenergy EVAC system.