Skip to content
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
50 changes: 34 additions & 16 deletions packages/react/src/editor/BlockNoteView.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -202,6 +202,7 @@ function BlockNoteViewComponent<
<BlockNoteViewContainer
className={className}
renderEditor={renderEditor}
editable={editable}
editorColorScheme={editorColorScheme}
ref={ref}
{...rest}
Expand All @@ -221,26 +222,34 @@ const BlockNoteViewContainer = React.forwardRef<
HTMLDivElement,
{
renderEditor: boolean;
editable?: boolean;
editorColorScheme: "light" | "dark";
children: ReactNode;
} & Omit<
HTMLAttributes<HTMLDivElement>,
"onChange" | "onSelectionChange" | "children"
>
>(({ className, renderEditor, editorColorScheme, children, ...rest }, ref) => (
<div
className={mergeCSSClasses("bn-container", editorColorScheme, className)}
data-color-scheme={editorColorScheme}
{...rest}
ref={ref}
>
{renderEditor ? (
<BlockNoteViewEditor>{children}</BlockNoteViewEditor>
) : (
children
)}
</div>
));
>(
(
{ className, renderEditor, editable, editorColorScheme, children, ...rest },
ref,
) => (
<div
className={mergeCSSClasses("bn-container", editorColorScheme, className)}
data-color-scheme={editorColorScheme}
{...rest}
ref={ref}
>
{renderEditor ? (
<BlockNoteViewEditor editable={editable}>
{children}
</BlockNoteViewEditor>
) : (
children
)}
</div>
),
);

// https://fettblog.eu/typescript-react-generic-forward-refs/
export const BlockNoteViewRaw = React.forwardRef(BlockNoteViewComponent) as <
Expand All @@ -260,7 +269,10 @@ export const BlockNoteViewRaw = React.forwardRef(BlockNoteViewComponent) as <
* Renders the contentEditable editor itself (.bn-editor element) and the
* default UI elements.
*/
export const BlockNoteViewEditor = (props: { children?: ReactNode }) => {
export const BlockNoteViewEditor = (props: {
editable?: boolean;
children?: ReactNode;
}) => {
const ctx = useBlockNoteViewContext()!;
const editor = useBlockNoteEditor();

Expand All @@ -270,9 +282,15 @@ export const BlockNoteViewEditor = (props: { children?: ReactNode }) => {

const mount = useCallback(
(element: HTMLElement | null) => {
if (
props.editable !== undefined &&
props.editable !== editor.isEditable
) {
editor.isEditable = props.editable;
}
editor.mount(element, portalManager);
},
[editor, portalManager],
[editor, portalManager, props.editable],
);

return (
Expand Down
Loading