Skip to content

fix: add data attribute for correct react rendering #1954

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 25, 2025
Merged

fix: add data attribute for correct react rendering #1954

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2c2ae42
fix: add data attribute for correct react rendering
nperez0111 Aug 22, 2025
581b88d
Merge branch 'main' into fix/1844
nperez0111 Aug 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@
"@shikijs/langs-precompiled": "^3.2.1",
"@shikijs/themes": "^3.2.1",
"@shikijs/types": "^3.2.1",
"@tiptap/core": "^2.12.0",
"@tiptap/core": "^2.26.1",
"@uppy/core": "^3.13.1",
"@uppy/dashboard": "^3.9.1",
"@uppy/drag-drop": "^3.1.1",
Expand Down
2 changes: 1 addition & 1 deletion examples/08-extensions/01-tiptap-arrow-conversion/.bnexample.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,6 @@
"tags": ["Extension"],
"pro": true,
"dependencies": {
"@tiptap/core": "^2.12.0"
"@tiptap/core": "^2.26.1"
}
}
2 changes: 1 addition & 1 deletion examples/08-extensions/01-tiptap-arrow-conversion/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
"@blocknote/shadcn": "latest",
"react": "^19.1.0",
"react-dom": "^19.1.0",
"@tiptap/core": "^2.12.0"
"@tiptap/core": "^2.26.1"
},
"devDependencies": {
"@types/react": "^19.1.0",
Expand Down
30 changes: 15 additions & 15 deletions packages/core/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,21 +76,21 @@
"dependencies": {
"@emoji-mart/data": "^1.2.1",
"@shikijs/types": "3.2.1",
"@tiptap/core": "^2.12.0",
"@tiptap/extension-bold": "^2.11.5",
"@tiptap/extension-code": "^2.11.5",
"@tiptap/extension-gapcursor": "^2.11.5",
"@tiptap/extension-history": "^2.11.5",
"@tiptap/extension-horizontal-rule": "^2.11.5",
"@tiptap/extension-italic": "^2.11.5",
"@tiptap/extension-link": "^2.11.5",
"@tiptap/extension-paragraph": "^2.11.5",
"@tiptap/extension-strike": "^2.11.5",
"@tiptap/extension-table-cell": "^2.11.5",
"@tiptap/extension-table-header": "^2.11.5",
"@tiptap/extension-text": "^2.11.5",
"@tiptap/extension-underline": "^2.11.5",
"@tiptap/pm": "^2.12.0",
"@tiptap/core": "^2.26.1",
"@tiptap/extension-bold": "^2.26.1",
"@tiptap/extension-code": "^2.26.1",
"@tiptap/extension-gapcursor": "^2.26.1",
"@tiptap/extension-history": "^2.26.1",
"@tiptap/extension-horizontal-rule": "^2.26.1",
"@tiptap/extension-italic": "^2.26.1",
"@tiptap/extension-link": "^2.26.1",
"@tiptap/extension-paragraph": "^2.26.1",
"@tiptap/extension-strike": "^2.26.1",
"@tiptap/extension-table-cell": "^2.26.1",
"@tiptap/extension-table-header": "^2.26.1",
"@tiptap/extension-text": "^2.26.1",
"@tiptap/extension-underline": "^2.26.1",
"@tiptap/pm": "^2.26.1",
"emoji-mart": "^5.6.0",
"hast-util-from-dom": "^5.0.1",
"prosemirror-dropcursor": "^1.8.2",
Expand Down
6 changes: 3 additions & 3 deletions packages/react/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,9 +61,9 @@
"@blocknote/core": "0.35.0",
"@emoji-mart/data": "^1.2.1",
"@floating-ui/react": "^0.26.4",
"@tiptap/core": "^2.12.0",
"@tiptap/pm": "^2.12.0",
"@tiptap/react": "^2.12.0",
"@tiptap/core": "^2.26.1",
"@tiptap/pm": "^2.26.1",
"@tiptap/react": "^2.26.1",
"emoji-mart": "^5.6.0",
"lodash.merge": "^4.6.2",
"react-icons": "^5.2.1"
Expand Down
1 change: 1 addition & 0 deletions packages/react/src/schema/ReactBlockSpec.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -194,6 +194,7 @@ export function createReactBlockSpec<
"bn-inline-content",
element.className,
);
element.dataset.nodeViewContent = "";
}
}}
/>
Expand Down
4 changes: 2 additions & 2 deletions packages/server-util/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,8 +58,8 @@
"dependencies": {
"@blocknote/core": "0.35.0",
"@blocknote/react": "0.35.0",
"@tiptap/core": "^2.12.0",
"@tiptap/pm": "^2.12.0",
"@tiptap/core": "^2.26.1",
"@tiptap/pm": "^2.26.1",
"jsdom": "^25.0.1",
"y-prosemirror": "^1.3.4",
"y-protocols": "^1.0.6",
Expand Down
6 changes: 3 additions & 3 deletions packages/xl-ai/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@
"@blocknote/prosemirror-suggest-changes": "^0.1.3",
"@blocknote/react": "0.35.0",
"@floating-ui/react": "^0.26.4",
"@tiptap/core": "^2.12.0",
"@tiptap/core": "^2.26.1",
"ai": "^4.3.15",
"lodash.isequal": "^4.5.0",
"prosemirror-changeset": "^2.3.0",
Expand All @@ -88,12 +88,12 @@
"zustand": "^5.0.3"
},
"devDependencies": {
"@ai-sdk/anthropic": "^1.2.12",
"@ai-sdk/google": "^1.2.20",
"@ai-sdk/groq": "^1.2.9",
"@ai-sdk/mistral": "^1.2.8",
"@ai-sdk/openai": "^1.3.22",
"@ai-sdk/openai-compatible": "^0.2.14",
"@ai-sdk/anthropic": "^1.2.12",
"@ai-sdk/google": "^1.2.20",
"@mswjs/interceptors": "^0.37.5",
"@types/diff": "^6.0.0",
"@types/json-diff": "^1.0.3",
Expand Down
2 changes: 1 addition & 1 deletion packages/xl-multi-column/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@
"dependencies": {
"@blocknote/core": "0.35.0",
"@blocknote/react": "0.35.0",
"@tiptap/core": "^2.12.0",
"@tiptap/core": "^2.26.1",
"prosemirror-model": "^1.25.1",
"prosemirror-state": "^1.4.3",
"prosemirror-tables": "^1.3.7",
Expand Down
6 changes: 3 additions & 3 deletions playground/src/examples.gen.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -399,7 +399,7 @@
"pathFromRoot": "examples/03-ui-components",
"slug": "ui-components"
},
"readme": "In this example, we add a blue text/background color and code style button to the Formatting Toolbar.\n\n**Try it out:** Select some text to open the Formatting Toolbar, and click one of the new buttons!\n\n**Relevant Docs:**\n\n- [Changing the Formatting Toolbar](/docs/react/components/formatting-toolbar)\n- [Manipulating Inline Content](/docs/reference/editor/manipulating-content)\n- [Editor Setup](/docs/getting-started/editor-setup)"
"readme": "In this example, we add a blue text/background color and code style button to the Formatting Toolbar. We also make sure it only shows up when some text is selected.\n\n**Try it out:** Select some text to open the Formatting Toolbar, and click one of the new buttons!\n\n**Relevant Docs:**\n\n- [Changing the Formatting Toolbar](/docs/react/components/formatting-toolbar)\n- [Manipulating Inline Content](/docs/reference/editor/manipulating-content)\n- [Editor Setup](/docs/getting-started/editor-setup)"
},
{
"projectSlug": "formatting-toolbar-block-type-items",
Expand Down Expand Up @@ -749,7 +749,7 @@
"pathFromRoot": "examples/03-ui-components",
"slug": "ui-components"
},
"readme": "In this example, we add a button to the Link Toolbar which opens a browser alert.\n\n**Try it out:** Hover the link open the Link Toolbar, and click the new \"Open Alert\" button!\n\n**Relevant Docs:**\n\n- [Changing the Link Toolbar](/docs/react/components/link-toolbar)\n- [Editor Setup](/docs/getting-started/editor-setup)"
"readme": "In this example, we add a button to the Link Toolbar which opens a browser alert.\n\n**Try it out:** Hover the link open the Link Toolbar, and click the new \"Open Alert\" button!\n\n**Relevant Docs:**\n\n- [Editor Setup](/docs/getting-started/editor-setup)"
},
{
"projectSlug": "advanced-tables-2",
Expand Down Expand Up @@ -1546,7 +1546,7 @@
],
"pro": true,
"dependencies": {
"@tiptap/core": "^2.12.0"
"@tiptap/core": "^2.26.1"
} as any
},
"title": "TipTap extension (arrow InputRule)",
Expand Down
Loading
Loading