Skip to content

[CRITICAL] Fix: Infinite render loop when selecting all content (Ctrl+A / Cmd+A) #1956

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 25, 2025
Merged

[CRITICAL] Fix: Infinite render loop when selecting all content (Ctrl+A / Cmd+A) #1956

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions packages/core/src/extensions/FormattingToolbar/FormattingToolbarPlugin.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -206,15 +206,14 @@ export class FormattingToolbarView implements PluginView {
// individually in each button.
const newReferencePos = this.getSelectionBoundingBox();

// Workaround to ensure the correct reference position when rendering
// Workaround to ensure the correct reference position when rendering
// React components. Without this, e.g. updating styles on React inline
// content causes the formatting toolbar to be in the wrong place. We
// know the component has not yet rendered if the reference position has
// content causes the formatting toolbar to be in the wrong place. We
// know the component has not yet rendered if the reference position has
// zero dimensions.
if (
newReferencePos.x === 0 ||
newReferencePos.y === 0 ||
newReferencePos.width === 0 ||
newReferencePos.height === 0
) {
// Updates the reference position again following the render.
Expand Down
Loading