-
-
Notifications
You must be signed in to change notification settings - Fork 637
feat(core): support for Tiptap V3 #2001
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
| ], | ||
| getTestSelection: (editor: BlockNoteEditor<any, any, any>) => { | ||
| const posInfo = getNodeById("ref2", editor.prosemirrorState.doc)!; | ||
| // { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@YousefED, I looked into this & could not figure out what the root cause of this is. The update tool seems to be replacing the block when it should only be partially updating the block? I'm not entirely certain what is going on here, can you take a look at this for me?
@blocknote/ariakit
@blocknote/code-block
@blocknote/core
@blocknote/mantine
@blocknote/react
@blocknote/server-util
@blocknote/shadcn
@blocknote/xl-ai
@blocknote/xl-docx-exporter
@blocknote/xl-email-exporter
@blocknote/xl-multi-column
@blocknote/xl-odt-exporter
@blocknote/xl-pdf-exporter
commit: |
14ebdab to
5b6f5c6
Compare
|
@nperez0111 does this update mean that blocknotejs should be able to support SSR now in environments like Next.js, just like tiptap? |
|
@MetaMmodern, Tiptap does not support SSR in Next.js & so this change has no effect on our SSR support, Next.js has very specific requirements to render in SSR which is fundamentally incompatible with rendering in ProseMirror which requires a DOM to function properly. |
This PR is meant to add support for Tiptap V3, there are a couple of things which it depends on:
default-blocksbranchBlockNoteTiptapEditorif it does not happen quick enough): perf(core): providemarkViews&nodeViewsonviewcreation ueberdosis/tiptap#6946