fix: remove @hocuspocus/provider peer dependency by inlining tiptap comment types BLO-1064#2564
fix: remove @hocuspocus/provider peer dependency by inlining tiptap comment types BLO-1064#2564nperez0111 merged 3 commits intomainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Important Review skippedReview was skipped due to path filters ⛔ Files ignored due to path filters (1)
CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
📝 WalkthroughWalkthroughThis change migrates the Tiptap collaboration system from Hocuspocus provider types to locally-defined types. It removes the Hocuspocus peer dependency, updates import paths to use a new local types module, and introduces comprehensive type definitions for collaboration data structures and provider interface. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Comment |
@blocknote/ariakit
@blocknote/code-block
@blocknote/core
@blocknote/mantine
@blocknote/react
@blocknote/server-util
@blocknote/shadcn
@blocknote/xl-ai
@blocknote/xl-docx-exporter
@blocknote/xl-email-exporter
@blocknote/xl-multi-column
@blocknote/xl-odt-exporter
@blocknote/xl-pdf-exporter
commit: |
Summary
Remove the
@hocuspocus/providerpeer dependency from@blocknote/coreby inlining the needed Tiptap comment types locally.closes #2547
Rationale
The comment-related types (
TCollabComment,TCollabThread,TiptapCollabProvider) have moved from@hocuspocus/providerto@tiptap-pro/provider, which is a private package we don't want to depend on. Inlining these types removes the peer dependency entirely.Changes
@hocuspocus/providerfrompeerDependenciesinpackages/core/package.jsonpackages/core/src/comments/threadstore/tiptap/types.tswith types extracted from hocuspocus v2.15.3TipTapThreadStore.tsto use the local typesImpact
Consumers no longer need to install
@hocuspocus/provideras a peer dependency. No runtime behavior changes.Checklist
Made with Cursor
Summary by CodeRabbit
Documentation
Chores
New Features