make some parts of the grammar easier to read and more DRY, format with the default Langium formatter#2
Open
trusktr wants to merge 1 commit intoTypeFox:mainfrom
Open
Conversation
…th the default Langium formatter
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I felt like the formatting of the grammar was a little difficult to read, namely the function/method calls, so I formatted them and took out the arguments lists into a shared fragment. I also formatted the rest of the file using Langium's default grammar formatter.
The new formatting is also closer to how JavaScript/TypeScript people format code.
Sidenote, the formatter wants to un-indent the comment, which was out of my controls:
The formatter would need a tweak so that it will instead do this: