Skip to content

chore(oxfmt): ignore clangd include files list#1028

Merged
kaisalmen merged 3 commits intoTypeFox:oxfmtfrom
Boshen:fix/clangd-include-markdown-list
Mar 3, 2026
Merged

chore(oxfmt): ignore clangd include files list#1028
kaisalmen merged 3 commits intoTypeFox:oxfmtfrom
Boshen:fix/clangd-include-markdown-list

Conversation

@Boshen
Copy link
Contributor

@Boshen Boshen commented Mar 3, 2026

Summary

  • keep packages/examples/resources/clangd/clangd-include.files.md unchanged
  • add this file to .oxfmtrc.json ignorePatterns

Why

  • this markdown file can be pathologically slow for markdown formatting
  • excluding it in oxfmt config avoids the slowdown during repository formatting checks

Context: oxc-project/oxc#19929 (comment)

resolves oxc-project/oxc#19929

@Boshen Boshen changed the base branch from main to oxfmt March 3, 2026 04:21
@Boshen Boshen marked this pull request as draft March 3, 2026 04:23
@Boshen Boshen force-pushed the fix/clangd-include-markdown-list branch from cc9b757 to 55b45bd Compare March 3, 2026 04:24
@Boshen Boshen changed the title fix(markdown): use list items in clangd include file list chore(oxfmt): ignore clangd include files list Mar 3, 2026
@Boshen Boshen marked this pull request as ready for review March 3, 2026 04:33
Copy link
Collaborator

@kaisalmen kaisalmen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for the investigation. 🎉

@kaisalmen kaisalmen merged commit eb6e160 into TypeFox:oxfmt Mar 3, 2026
kaisalmen pushed a commit that referenced this pull request Mar 4, 2026
* chore(oxfmt): ignore clangd include files list
* chore(oxfmt): document clangd include ignore reason
* chore(oxfmt): clarify ignore rationale for markdown glob
kaisalmen pushed a commit that referenced this pull request Mar 5, 2026
* chore(oxfmt): ignore clangd include files list
* chore(oxfmt): document clangd include ignore reason
* chore(oxfmt): clarify ignore rationale for markdown glob
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants