Conversation
…itorconfig - Update dependencies
* chore(oxfmt): ignore clangd include files list * chore(oxfmt): document clangd include ignore reason * chore(oxfmt): clarify ignore rationale for markdown glob
kaisalmen
changed the title
Collaborator
Author
|
@CGNonofr btw, during the switch to oxfmt I made this observation. |
CGNonofr
approved these changes
Mar 5, 2026
Collaborator
Author
@CGNonofr any thoughts on this? You use two spaces in mva. |
Collaborator
That's an infinite debate :) Both are fine as long as it's consistent and enforced |
Collaborator
Author
I know, but I am in for it (I had a different opinion in the past). The default is now 2 and everything is formatted accordingly and the tools will ensure it stays consistent. |
CGNonofr
approved these changes
Mar 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The code formatting wasn't really bad. Line limit is now 140 what makes looking at diffs easier, IMO.
Most changes are in HTML and json related content as I set the spacing to 2 there. The package.json files were reordered according.
VS Code formats on save now. editorconfig is dropped as it is no longer needed.
Btw, do you prefer two spaces for TypeScript? I am open to change that as well.