Fix swc issues #2062
Merged
Fix swc issues #2062
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… emitting import assertions as `with` which node does not understand
Codecov Report
|
…undefined for sourcemap
Fix issue introduced by swc 1.3.85 with module options that are now forbidden instead of ignored for certain module types remove failing useDefineForClassFields case because I forgot that implicit compiler options were in effect, so default target is actually much higher than I expected
This was referenced Sep 16, 2023
|
@cspotcode , please release |
|
Hey @cspotcode - thanks for working on this change! Do you know when it'll be possible to ship a new release? I couldn't see any workflow or doc on the process, but please let me know if I can help at all. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues fixed
The latest version of swc renamed some options.
Also, a new option is necessary to tell swc to emit import assertions with the
assertkeyword instead ofwith.This effectively requires a newer version of SWC, so I bumped the minimum required version
ts-node was not passing the correct
useDefineForClassFieldsvalue to swc to match the user's tsconfig / tsc's behavior.ts-node was erroring when custom transpilers did not return a sourcemap.
ts-node did not pass jsxImportSource to swc
swc 1.3.85 now forbids irrelevant
module.options. For example, thenoInteropoption has no effect ifmodule.type == 'es6', and 1.3.85 now raises an error if you try to passmodule: {type: 'es6', noInterop: true}. ts-node now conditionally passes those options to avoid this errorTickets resolved
Fixes #2059
Fixes #2056
Fixes #2051
Replaces #2057
Replaces #2049
Replaces #1968
Fixes #1996
Replaces, fixes #1852