Align naming and member order with sibling repo conventions#58
Merged
Align naming and member order with sibling repo conventions#58
Conversation
Co-authored-by: Tyrrrz <1935960+Tyrrrz@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix codebase inconsistencies by renaming methods and adjusting order
Align naming and member order with sibling repo conventions
Feb 27, 2026
There was a problem hiding this comment.
Pull request overview
Aligns this repo’s utilities with naming and member-order conventions used in sibling repositories, keeping extension APIs and helper patterns consistent across related projects.
Changes:
- Renamed
StringExtensions.NullIfEmptyOrWhiteSpace()toNullIfWhiteSpace()and updated all in-repo call sites. - Reordered
Disposablemembers so the static factoryCreate()appears beforeDispose().
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| DotnetRuntimeBootstrapper.AppHost.Core/Utils/Url.cs | Updates TryExtractFileName() to use the renamed NullIfWhiteSpace() extension. |
| DotnetRuntimeBootstrapper.AppHost.Core/Utils/Extensions/StringExtensions.cs | Renames the extension member to NullIfWhiteSpace() (behavior remains IsNullOrWhiteSpace-based). |
| DotnetRuntimeBootstrapper.AppHost.Core/Utils/Disposable.cs | Reorders members to place Create() above Dispose(). |
| DotnetRuntimeBootstrapper.AppHost.Core/TargetAssembly.cs | Updates Resolve() to use NullIfWhiteSpace() for ProductName normalization. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Tyrrrz
approved these changes
Feb 27, 2026
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. Thanks for integrating Codecov - We've got you covered ☂️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two minor inconsistencies with sibling repos (
YoutubeDownloader,DiscordChatExporter,LightBulb.PlatformInterop).StringExtensions: RenameNullIfEmptyOrWhiteSpace()→NullIfWhiteSpace()and update all call sites (TargetAssembly.cs,Url.cs)Disposable: MoveCreate()aboveDispose()to match conventional static-factory-before-instance-method orderingOriginal prompt
This pull request was created from Copilot chat.
🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.