Re-release under new GUID to remove EFI_DT_RESERVE_MEMORY and Flags argument#3
Open
dimorinny wants to merge 1 commit intoU-Boot-EFI:masterfrom
Open
Re-release under new GUID to remove EFI_DT_RESERVE_MEMORY and Flags argument#3dimorinny wants to merge 1 commit intoU-Boot-EFI:masterfrom
dimorinny wants to merge 1 commit intoU-Boot-EFI:masterfrom
Conversation
Removes EFI_DT_RESERVE_MEMORY and Flags to avoid: 1. Mixing DT fixup and reserve memory functionality 2. Proposed EFI_DT_RESERVE_MEMORY, which is unreliable Signed-off-by: Dmitrii Merkurev <dimorinny@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Due to feedback from EDK2 maintainers,
EFI_DT_FIXUP_PROTOCOLcannot be upstreamed into EDK2 or the UEFI spec as-is.Following the proposals from the EDK2/UEFI maintainers, we should:
EFI_DT_RESERVE_MEMORY, as it is unrelated to DT fix-ups and unreliable in its current state.EFI_prefix, since this protocol is not yet part of the official UEFI specification.I am uploading the proposed signature and specification to collect feedback. I don't believe we need to override
EFI_DT_FIXUPimmediately since it is already in use; instead, I propose to create a separateU-boot-EFI/DEVICETREE_FIXUP_PROTOCOLor a distinct branch within this repository.Please let me know your thoughts on this proposal.