Open
Conversation
Roozki
approved these changes
Feb 3, 2026
Contributor
Roozki
left a comment
Roozki
left a comment
There was a problem hiding this comment.
Looks good, but we should better seperate the old driver and new driver.
Approving, but before we merge we need to test the old arm and make sure it still works.
either in this PR or a followup PR, lets make 3 header files, 1 common file for both old arm and new arm (for joint names, common types etc), and 1 specific header for each arm. Might need some other refactors in arm_control but ill take a look at that later
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add some code for moteus controller.