Motor Model #3
Open
Motor Model #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated to make concise and sweep more accurately to optimize torque and rpm
Lucien950
commented
Dec 1, 2025
Comment on lines
+31
to
+40
| switch chosenTemp | ||
| case 80 | ||
| dat = load('A2370DD_T80C.mat'); | ||
| case 100 | ||
| dat = load('A2370DD_T100C.mat'); | ||
| case 120 | ||
| dat = load('A2370DD_T120C.mat'); | ||
| otherwise | ||
| error('Unexpected temperature selection.'); | ||
| end |
| error('Unexpected temperature selection.'); | ||
| end | ||
|
|
||
| notes = {}; |
Contributor
Author
There was a problem hiding this comment.
previously discussed notes method
Comment on lines
+27
to
+29
| availableTemps = [80 100 120]; | ||
| [~, idxNearest] = min(abs(availableTemps - Temp)); | ||
| chosenTemp = availableTemps(idxNearest); |
Contributor
Author
There was a problem hiding this comment.
later interpolation?
| % Derive speed and current axes from matrix dimensions: | ||
| % assume speeds from 0 to 20000 rpm across NR rows (uniform) | ||
| % assume currents from 0 to 105 A across NC columns (uniform) | ||
| speeds = linspace(0,20000,NR).'; % column vector, rpm |
Contributor
Author
There was a problem hiding this comment.
take speed as input (as previously discussed)
Comment on lines
+82
to
+85
| % Check voltage satisfied (with tolerance) | ||
| v_ok = (Vv <= V_dc + epsV); | ||
| % Check torque satisfied (with tolerance downward) | ||
| t_ok = (Tv >= T_dmd - epsT); |
Contributor
Author
There was a problem hiding this comment.
personal preference but write it as |x-y| <= eps
Comment on lines
+78
to
+110
| for row = NR:-1:1 % highest speed first | ||
| for col = 1:NC % lowest current first | ||
| Tv = Tmat(row,col); | ||
| Vv = Vmat(row,col); | ||
| % Check voltage satisfied (with tolerance) | ||
| v_ok = (Vv <= V_dc + epsV); | ||
| % Check torque satisfied (with tolerance downward) | ||
| t_ok = (Tv >= T_dmd - epsT); | ||
| if v_ok && t_ok | ||
| % Exact acceptable operating point found (prefer high RPM, then low current) | ||
| selected_row = row; | ||
| selected_col = col; | ||
| found_exact = true; | ||
| notes{end+1} = sprintf('Exact operating point found at row %d (%.1f rpm), col %d (I=%.3g A): T=%.3g, V=%.3g.', ... | ||
| row, speeds(row), col, currents(col), Tv, Vv); | ||
| break; % break inner loop (we found the best point for this high RPM) | ||
| else | ||
| % If voltage satisfied but torque not, consider as fallback candidate | ||
| if v_ok && ~t_ok | ||
| if Tv > fallback_T | ||
| fallback_T = Tv; | ||
| fallback_row = row; | ||
| fallback_col = col; | ||
| fallback_exists = true; | ||
| end | ||
| end | ||
| % Otherwise (V not ok) we do nothing special, continue scanning | ||
| end | ||
| end | ||
| if found_exact | ||
| break; % exit outer loop | ||
| end | ||
| end |
Contributor
Author
There was a problem hiding this comment.
you can replace this with (assuming dimensions of Vmat, Tmat are the same)
Suggested change
| for row = NR:-1:1 % highest speed first | |
| for col = 1:NC % lowest current first | |
| Tv = Tmat(row,col); | |
| Vv = Vmat(row,col); | |
| % Check voltage satisfied (with tolerance) | |
| v_ok = (Vv <= V_dc + epsV); | |
| % Check torque satisfied (with tolerance downward) | |
| t_ok = (Tv >= T_dmd - epsT); | |
| if v_ok && t_ok | |
| % Exact acceptable operating point found (prefer high RPM, then low current) | |
| selected_row = row; | |
| selected_col = col; | |
| found_exact = true; | |
| notes{end+1} = sprintf('Exact operating point found at row %d (%.1f rpm), col %d (I=%.3g A): T=%.3g, V=%.3g.', ... | |
| row, speeds(row), col, currents(col), Tv, Vv); | |
| break; % break inner loop (we found the best point for this high RPM) | |
| else | |
| % If voltage satisfied but torque not, consider as fallback candidate | |
| if v_ok && ~t_ok | |
| if Tv > fallback_T | |
| fallback_T = Tv; | |
| fallback_row = row; | |
| fallback_col = col; | |
| fallback_exists = true; | |
| end | |
| end | |
| % Otherwise (V not ok) we do nothing special, continue scanning | |
| end | |
| end | |
| if found_exact | |
| break; % exit outer loop | |
| end | |
| end | |
| [n, m] = size(Vmat) | |
| k = find(abs(Vmat - T_dmd) <= epsT & abs(Vmat - V_dc) <= epsV, 1, 'first') | |
| found_exact=size(k) > 0 | |
| row, col = mod(k[0], n), floorDiv(k[0] / n) |
Contributor
Author
There was a problem hiding this comment.
(double check my syntax but this is the main idea)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.