add pipeline struct to replace ProcessingConfig and WindowingConfig#85
Open
itang06 wants to merge 4 commits intofeature/pipeline-structfrom
Open
add pipeline struct to replace ProcessingConfig and WindowingConfig#85itang06 wants to merge 4 commits intofeature/pipeline-structfrom
itang06 wants to merge 4 commits intofeature/pipeline-structfrom
Conversation
|
❌ PR approval conditions NOT satisfied. At least 1 team lead OR 2 team members must approve before merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
combined
ProcessingConfigandWindowingConfigstructs into a singlePipelinestruct that the frontend sends as one JSON message at the start of a WebSocket sessionHow?
pipeline.rsinshared-logicwith aPipelinestruct containing aVec<Node>, whereNodeis an enum withWindow,Preprocessing, andMLvariants, with each carrying their own config structProcessingConfigandWindowingConfigfromlsl.rsand replaced references throughoutlsl.rs,bc.rs, andwebsocket-server/main.rswith the newPipelinetypehandle_connectioninmain.rsto loop until the first non null text message (pipeline JSON) instead of the previous 500ms timeout phase that waited for two separate config messagessession_idtoStringinWebSocketInitMessageto match the frontend's typeTesting
ws://localhost:8080via Postman and sent the pipeline JSON, and Docker logs confirmedReceived pipeline with 3 nodesand EEG data packets streamed back successfullypostman message
docker logs
---