Skip to content

Comments

Normalizing Objectives#280

Closed
patrick-5546 wants to merge 10 commits intomainfrom
akash/normalising_obj_funcs
Closed

Normalizing Objectives#280
patrick-5546 wants to merge 10 commits intomainfrom
akash/normalising_obj_funcs

Conversation

@patrick-5546
Copy link
Member

@patrick-5546 patrick-5546 commented Mar 9, 2024

Description

  • Added two functions in the parent class: (i) Creates random sample states; (ii) Compares every pair in that sample and picks the maximum motionCost()
  • Inherited these functions in each Objective class to find the max_motionCost for each objective function
  • Modified the motionCost() function of each Objective class to normalise its cost using max_motionCost

Verification

  • Verified using a simple setup example problem
  • Haven't included unit tests

Resources

@akash-venkateshwaran
Copy link

Hi Patrick, I have completed the normalization. Done the testing of speed obj as well
There an issue in logic for normalization where I got 1.0 for every pair of random samples. I have fixed that bug.
Also there is a problem with SpeedObjectiveMethod.SAILBOT_TIME where no matter how many samples I use I get diff max_motion_cost every time I run it. I don't think its a huge issue. Please check it out

Copy link
Member Author

@patrick-5546 patrick-5546 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple comments

  • Local pathfinding tests now take a really long time to run (went from 6s to >1min). Did you observe the same on your machine? Any idea what may be the cause?
  • Why do you think SAILBOT_TIME doesn't converge and why isn't it an issue?
  • How much latency does setting the num_samples to 2k add for SAILBOT_TIME?
    • It took a lot of time for me to run this individually 10 times (4s vs. 426s)

@FireBoyAJ24 FireBoyAJ24 self-requested a review February 1, 2025 21:57
@FireBoyAJ24
Copy link
Contributor

We will redo normalizing objectives as there are issues with the implementation, with adding pyompl bindings, and the code itself.

@FireBoyAJ24 FireBoyAJ24 closed this Mar 1, 2025
@FireBoyAJ24 FireBoyAJ24 changed the title Local pathfinding PR 66 Normalizing Objectives Mar 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

path Pathfinding team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants