Skip to content

Local Transceiver: Fix Issue with Parsing Mailbox#500

Merged
samdai01 merged 6 commits intomainfrom
user/jng468/local_transceiver_clear_mailbox
Mar 8, 2025
Merged

Local Transceiver: Fix Issue with Parsing Mailbox#500
samdai01 merged 6 commits intomainfrom
user/jng468/local_transceiver_clear_mailbox

Conversation

@Jng468
Copy link
Copy Markdown
Contributor

@Jng468 Jng468 commented Mar 1, 2025

Description

  • This PR is to address the issue of parseReceiveMessageBlackbox hanging when run twice. The issue was identified to be caused by a lingering "OK" in the mailbox
  • ReadRsp() has been modified to address this issue

Verification

  • Ran parseReceiveMessageBlackbox several times back-to-back
  • Ran parseReceiveMessageBlackbox with different data values

Resources

@Jng468 Jng468 requested a review from samdai01 as a code owner March 1, 2025 20:04
@Jng468
Copy link
Copy Markdown
Contributor Author

Jng468 commented Mar 1, 2025

Some issues caused by merging main into the branch. Working on resolving that right now

@Jng468 Jng468 force-pushed the user/jng468/local_transceiver_clear_mailbox branch from a78faf8 to cb3e42e Compare March 6, 2025 03:53
@Jng468 Jng468 requested a review from JordanChen123 as a code owner March 6, 2025 03:53
@samdai01 samdai01 merged commit b4d0cb0 into main Mar 8, 2025
10 checks passed
@samdai01 samdai01 deleted the user/jng468/local_transceiver_clear_mailbox branch March 8, 2025 20:40
FireBoyAJ24 added a commit that referenced this pull request Apr 2, 2025
* Local Transceiver: Fix Issue with Parsing Mailbox (#500)

* this is preliminary remember to clean up

* Local transceiver updated to correct receive format, but still need to fix hanging OK issue

* try new readrsp

* Modified readRsp to read until STATUS_OK instead of DELIMITER

* test with different value

* restore deleted website file

---------

Co-authored-by: lross03 <liamyr0802@gmail.com>

* Revert "Add ROS workflows"

* Updating the integration test workflow

* Make it temperory run the workflow during a push to the branch

* Add pull request actions

* Adding integrationn test script

* Adjusting the script path

* Add chmod permissions

* Debug script location

* Adjusting the script

* Comment out chmod command

* Add chmod command

* Adjust Script run command

* Adjust the script path

* Adjusting script path

* Remove the extra sh

* Add execute permission to the bash script

* Added permissions to the path

* Make run_integration_tests.sh executable

---------

Co-authored-by: Jing <128339540+Jng468@users.noreply.github.com>
Co-authored-by: lross03 <liamyr0802@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants