-
Notifications
You must be signed in to change notification settings - Fork 3
Expand Speed Lookup Table #744
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
raghumanimehta
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not really requesting changes, but need clarification on a couple of things before merging.
| return ZERO_VECTOR_CONSTANT, 0.0 | ||
|
|
||
|
|
||
| def get_true_wind_angle(boat_heading_rad: float, tw_dir_rad: float) -> float: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you think we can perhaps use calculate_heading_diff from local_path.py?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, IF we can rename the function to something more generic that fits both the uses cases it would then be applied to.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's good for now. We have other things to worry about.
Description
This PR upgrades the
BOAT_SPEEDStable inompl_objectives.pyto cover more wind speeds and to follow an even more realistic/data informed velocity prediction model.The boat speed data was collected from polar data of a similar vessel here https://jieter.github.io/orc-data/site/#GRE/GRE1772/
The raw speed values from
polar_sailing_speed_prediction_datawere loaded into a 2d array, transformed from knots to kmph, scaled down so that the maximum value is 10 kmph (because that is our estimate of sailbot's top speed), and then transposed to obtain the new BOAT_SPEEDS array shown belowBelow is a polar plot of the data contained in the new BOAT_SPEEDS table.
Verification