Skip to content

Comments

Sending data for changing parameters through the visualizer ui#785

Merged
raghumanimehta merged 11 commits intomainfrom
AMaharaj16/visualizer-dash-params-change-776
Feb 16, 2026
Merged

Sending data for changing parameters through the visualizer ui#785
raghumanimehta merged 11 commits intomainfrom
AMaharaj16/visualizer-dash-params-change-776

Conversation

@AMaharaj16
Copy link
Contributor

Issue Link: #776

Summary

Adds inline wind controls to the existing visualizer UI, allowing true wind direction and speed to be adjusted live without launching a separate dashboard.

Details

Embedded numeric inputs for true wind direction and speed directly into the visualizer

Updates wind_params.yaml and applies changes via the existing script

Keeps all changes contained to visualizer.py

@AMaharaj16
Copy link
Contributor Author

Something to note is that adjusting the wind direction parameter doesn't change the arrow angle in the wind speed/direction visualization in the bottom right of the visualizer. Should I investigate that?

Copy link
Contributor

@raghumanimehta raghumanimehta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work!
There are some inconsistencies, please iron them out!

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds inline true-wind controls to the Dash visualizer so users can update mock wind parameters live (by rewriting wind_params.yaml and invoking the existing wind_params.sh loader) without using a separate dashboard/terminal workflow.

Changes:

  • Added Dash UI inputs + an “Apply Wind” button to set true wind direction/speed from the visualizer page.
  • Implemented YAML rewrite logic for mock_nodes/wind_params.yaml and a subprocess call to run mock_nodes/wind_params.sh.
  • Added a Dash callback to validate inputs and apply the updated parameters.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 6 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@MilcToast MilcToast added path Pathfinding team and removed path Pathfinding team labels Feb 8, 2026
Copy link
Contributor

@raghumanimehta raghumanimehta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Add the name of the text fields.
  • Remove "Applied wind ... " message after sometime.
  • Can you also move the fields to the bottom left cornere and move the main plot a bit above for cleanlineess. I will be adding more controls there soon.
    Thanks!

raghumanimehta
raghumanimehta previously approved these changes Feb 16, 2026
@raghumanimehta raghumanimehta enabled auto-merge (squash) February 16, 2026 05:06
@raghumanimehta raghumanimehta merged commit d912914 into main Feb 16, 2026
6 checks passed
@raghumanimehta raghumanimehta deleted the AMaharaj16/visualizer-dash-params-change-776 branch February 16, 2026 05:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants