User/Apps247/714-new-create-debug-send-at-function#786
Closed
User/Apps247/714-new-create-debug-send-at-function#786
Conversation
…ew-create-debug-send-at-function
…ded ros parameter debug_data_to_send to set the data to send. Untested.
…create-debug-send-at-function
…create-debug-send-at-function
Apps247
requested review from
FireBoyAJ24,
SPDonaghy and
lross03
as code owners
Removed commented-out code for AT::Line('\r') in rcvRsps calls.
Contributor
|
Merged in by #764 can close |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Resolves Create debug send function for local tansceiver satellite testing #714
Also resolves part of Local Transceiver: update send() and debugsend() to check connection before using satellite and look into clearing buffer before reading #764 (see last point below)
Created debugSendAT function, with a ros2 service debug_send_data and ros2 parameter debug_data_to_send
Updated local transceiver to use a log callback for debug and errors rather than cout and cerr. This is set by whoever initializes LocalTransceiver(). Use setLogCallbacks() to set. Currently the unit tests set it to use cout and cerr, and the ros2 service sets it to use ros logs.
Fixed \r extra character in issue with the clearSerialBuffer() function. This should also resolve the issue of stale buffer input from previous attempts affecting the current attempt. This resolves the clearing buffer part of Local Transceiver: update send() and debugsend() to check connection before using satellite and look into clearing buffer before reading #764 too