Fix misleading docstring for get_remaining_cost() regarding terminal cost#803
Draft
Fix misleading docstring for get_remaining_cost() regarding terminal cost#803
Conversation
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…ailbot/sailbot_workspace into raghumanimehta/778-get_cost Trust me bro
Co-authored-by: raghumanimehta <115026448+raghumanimehta@users.noreply.github.com>
Author
|
Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details. Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
Copilot
AI
changed the title
[WIP] Update implementation of terminal cost based on feedback
Fix misleading docstring for get_remaining_cost() regarding terminal cost
Feb 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The
get_remaining_cost()docstring claimed to include OMPL'sterminalCostin its calculation, but the implementation only accumulates motion costs. This is correct behavior since our objectives don't overrideterminalCost(defaults to 0), but the docstring was misleading.Updated
ompl_path.pydocstring to:Key distinction: OMPL's
terminalCostis an additional cost applied to the final state, not the cost of the last waypoint itself.Verification
Resources
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.