Skip to content

Comments

Fix misleading docstring for get_remaining_cost() regarding terminal cost#803

Draft
Copilot wants to merge 23 commits intomainfrom
copilot/sub-pr-798-another-one
Draft

Fix misleading docstring for get_remaining_cost() regarding terminal cost#803
Copilot wants to merge 23 commits intomainfrom
copilot/sub-pr-798-another-one

Conversation

Copy link

Copilot AI commented Feb 13, 2026

Description

The get_remaining_cost() docstring claimed to include OMPL's terminalCost in its calculation, but the implementation only accumulates motion costs. This is correct behavior since our objectives don't override terminalCost (defaults to 0), but the docstring was misleading.

Updated ompl_path.py docstring to:

  • Clarify that only motion costs are accumulated, not terminal/initial costs
  • Document the zero-cost assumption explicitly
  • Note that future non-zero terminal/initial costs require implementation updates

Key distinction: OMPL's terminalCost is an additional cost applied to the final state, not the cost of the last waypoint itself.

Verification

  • Docstring now matches implementation behavior
  • Code review passed
  • Security scan passed

Resources


✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Co-authored-by: raghumanimehta <115026448+raghumanimehta@users.noreply.github.com>
Copy link
Author

Copilot AI commented Feb 13, 2026

Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • ompl.kavrakilab.org
    • Triggering command: /home/REDACTED/work/_temp/ghcca-node/node/bin/node /home/REDACTED/work/_temp/ghcca-node/node/bin/node --enable-source-maps /home/REDACTED/work/_temp/copilot-developer-action-main/dist/index.js (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Copilot AI changed the title [WIP] Update implementation of terminal cost based on feedback Fix misleading docstring for get_remaining_cost() regarding terminal cost Feb 13, 2026
Copilot AI requested a review from raghumanimehta February 13, 2026 21:21
Base automatically changed from raghumanimehta/778-get_cost to main February 21, 2026 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants