feat: improve lesson search with fuzzy matching and highlighting#39
feat: improve lesson search with fuzzy matching and highlighting#39jt14den merged 4 commits intoUC-OSPO-Network:mainfrom
Conversation
|
Nice implementation of fuzzy search! The Fuse.js integration looks clean and the highlighting is a great UX improvement.
|
❌ PR checks failedOne or more validation checks failed. Please review the workflow logs to see what went wrong. Common issues:
|
|
Thanks! I addressed the security concern. |
✅ All PR checks passed!
The site builds successfully and all validation checks passed. |
ShouzhiWang
left a comment
There was a problem hiding this comment.
Thanks for adding fuzzy search and addressing the security issue. The search logic itself is a great improvement over strict matching.
However, the visual highlighting implementation causes some UIUX issues. Because fuzzy search matches non-contiguous characters, we often end up with "random" letters highlighted (e.g., searching "python" highlights individual letters 'p', 'y', 't' scattered across words), which looks buggy and creates visual noise.
Suggestion: remove the visual highlighting feature but keep the fuzzy search filtering logic.
✅ All PR checks passed!
The site builds successfully and all validation checks passed. |
This PR improves the lesson search by replacing exact string matching with fuzzy search using Fuse.js.
What was done
Notes
Fixes #31