FEATURE: Create individual lesson detail pages #63
Open
ShouzhiWang wants to merge 10 commits intostagingfrom
Open
FEATURE: Create individual lesson detail pages #63ShouzhiWang wants to merge 10 commits intostagingfrom
ShouzhiWang wants to merge 10 commits intostagingfrom
Conversation
…page layouts, navigation, and configuration to support them.
- Added TypeScript and @astrojs/check as devDependencies in package.json. - Enhanced the GitHub Actions workflow by streamlining validation steps and removing unnecessary checks. - Updated Folder and UnifiedNav components for better type safety and code readability. - Refactored pathway page to improve lesson filtering and grouping logic.
- Changed the schema for lessons to include new fields: author, license, timeRequired, and inLanguage. - Updated existing lesson JSON files to populate the new fields and ensure backward compatibility with the previous schema. - Normalized keywords to a string format for consistency. - Refactored the lesson retrieval logic to accommodate the new structure and maintain compatibility with the UI.
- Updated PathwayCard, Layout, home-new, and index pages to use import.meta.env.BASE_URL for generating URLs. - Adjusted keystatic.config.ts to change the condition for using GitHub storage based on environment variables.
…Google Sheet - Introduced new fields in keystatic.config.ts for enhanced lesson metadata, including topic, sortingId, dependsOn, learningObjectives, and more. - Updated the lesson migration script to normalize and populate these new fields from existing lesson data. - Enhanced lesson JSON files to include the new metadata fields, ensuring consistency and improved data structure for lessons.
- Updated LessonCard to wrap content in an anchor tag for direct navigation to lesson details. - Introduced a new Astro page for lesson details, including static paths generation and metadata formatting. - Enhanced lesson metadata handling and related lessons logic for improved user experience.
❌ PR checks failedOne or more validation checks failed. Please review the workflow logs to see what went wrong. Common issues:
|
1 similar comment
❌ PR checks failedOne or more validation checks failed. Please review the workflow logs to see what went wrong. Common issues:
|
jt14den
added
the
team: internal
Collaborator
|
Hi @ShouzhiWang, we've just completed a major cleanup and stabilization of the |
chore: add CODEOWNERS and auto-labeling workflow
…corporate accessibility tooling - Keep Keystatic CMS, content collections, lessons.ts as primary data source - Add main's audit:a11y script and accessibility devDependencies - Merge pr-check workflow: validate-data, validate-build, check-links - Use BASE_URL for all internal links (dev/prod compatibility) - Update LessonFilter to use Lesson type for content collection data - Accept deletion of getSheetData.js (replaced by getSheetData.ts) - Regenerate package-lock.json Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #28