Minor improvements: improved voyager notebooks + added conda installation instructions#280
Open
zachtheyek wants to merge 2 commits intoUCBerkeleySETI:masterfrom
Open
Minor improvements: improved voyager notebooks + added conda installation instructions#280zachtheyek wants to merge 2 commits intoUCBerkeleySETI:masterfrom
zachtheyek wants to merge 2 commits intoUCBerkeleySETI:masterfrom
Conversation
…py import to avoid matplotlib backend override. (2) Added more robust data checking before downloading voyager data
Author
|
edit: i suspect the imo if there's no reason to reset the matplotlib backend, a longer-term solution would be to remove that behavior from the core blimpy functionality altogether. perhaps it was unintentionally set to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains the following changes:
examples/voyager.ipynbandtutorial/blimpy_voyager_tour.ipynb, moved%matplotlib inlinecall to after the blimpy import.aggon import. To verify, in a fresh kernel, run:aggis a non-interactive, file-only renderer. In other words, it prevents plots from being displayed to the notebook/screen.%matplotlib inlineresets the backend tomodule://matplotlib_inline.backend_inline, but the previous sequencing was in the wrong order.examples/voyager.ipynbandtutorial/blimpy_voyager_tour.ipynb, changed the "get data" portions to first check whether the data exists, and if not, download it to the CWD.environment.ymlfile containing the same dependencies listed inrequirements.txt, alongside setup instructions inREADME.md.