Skip to content

Conversation

@kristinawlai
Copy link
Collaborator

@kristinawlai kristinawlai commented Oct 12, 2024

Specifying log scale in second cross-sectional antibody data plot

@codecov
Copy link

codecov bot commented Oct 12, 2024

Codecov Report

Attention: Patch coverage is 0% with 22 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
R/autoplot.summary.seroincidence.by.bar.R 0.00% 22 Missing ⚠️
Files with missing lines Coverage Δ
R/autoplot.summary.seroincidence.by.bar.R 0.00% <0.00%> (ø)

@kristinawlai kristinawlai marked this pull request as ready for review October 12, 2024 23:37
@github-actions
Copy link
Contributor

github-actions bot commented Oct 15, 2024

📖 https://ucd-serg.github.io/serocalculator/preview/pr308
Preview documentation for this PR (at commit 9fe73c2)

Copy link
Member

@d-morrison d-morrison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR! Two questions:

  1. Why are we applying the log scale manually instead of with the log = TRUE option for autoplot.pop_data()?
  2. @kaiemjoy, is this how we want the x-axis label for this graph? (preview here: https://ucd-serg.github.io/serocalculator/preview/pr308/articles/enteric_fever_example.html).

@d-morrison d-morrison requested a review from kaiemjoy October 15, 2024 01:19
@kristinawlai
Copy link
Collaborator Author

  1. Why are we applying the log scale manually instead of with the log = TRUE option for autoplot.pop_data()?

Only because I forgot that it existed :). Updated to use log = TRUE

Copy link
Collaborator

@kaiemjoy kaiemjoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think this looks good - remind me how to get the preview again?

@d-morrison
Copy link
Member

i think this looks good - remind me how to get the preview again?

@kaiemjoy there's a bot-generated comment up above with the url: #308 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants