Open
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR aims to adjust the behavior of snapshot testing in the sim_pop_data_multi test. The changes include removing the OS-specific skip on Linux and updating the snapshot call to include a digits parameter for rounding.
- Removed skip_on_os("linux") call.
- Updated snapshot test to round values with digits = 4.
Comments suppressed due to low confidence (2)
tests/testthat/test-sim_pop_data_multi.R:1
- Removing the skip_on_os("linux") call may cause the test to run on Linux where environment-specific differences could lead to failures. Please confirm that running the test on all OSes is intentional.
test_that("`sim_pop_data_multi()` works consistently", {
tests/testthat/test-sim_pop_data_multi.R:41
- Adding the 'digits = 4' parameter rounds the snapshot data, which can affect test outcomes. It would be beneficial to add a comment detailing the reason for this change to aid future maintainers.
ssdtools:::expect_snapshot_data(name = "pop_data_multi", digits = 4)
❌ 1 Tests Failed:
View the top 1 failed test(s) by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for taking the time to submit a pull request!
To maximize the chances of acceptance:
Fixes #issue-number(if relevant).-.testthat).For more information see Contributing.