Skip to content

try to not skip#447

Open
d-morrison wants to merge 2 commits intomainfrom
sim-pop-multi-no-skip
Open

try to not skip#447
d-morrison wants to merge 2 commits intomainfrom
sim-pop-multi-no-skip

Conversation

@d-morrison
Copy link
Member

Thank you for taking the time to submit a pull request!

To maximize the chances of acceptance:

  • The title of your PR should briefly describe the change.
  • The body of your PR should contain Fixes #issue-number (if relevant).
  • Commit/merge messages to be included in NEWS.md should begin with -.
  • Code should follow the tidyverse style guide.
  • Documentation should use roxygen2, with Markdown syntax.
  • Contributions should include unit tests (using testthat).

For more information see Contributing.

Copilot AI review requested due to automatic review settings June 27, 2025 10:21
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR aims to adjust the behavior of snapshot testing in the sim_pop_data_multi test. The changes include removing the OS-specific skip on Linux and updating the snapshot call to include a digits parameter for rounding.

  • Removed skip_on_os("linux") call.
  • Updated snapshot test to round values with digits = 4.
Comments suppressed due to low confidence (2)

tests/testthat/test-sim_pop_data_multi.R:1

  • Removing the skip_on_os("linux") call may cause the test to run on Linux where environment-specific differences could lead to failures. Please confirm that running the test on all OSes is intentional.
test_that("`sim_pop_data_multi()` works consistently", {

tests/testthat/test-sim_pop_data_multi.R:41

  • Adding the 'digits = 4' parameter rounds the snapshot data, which can affect test outcomes. It would be beneficial to add a comment detailing the reason for this change to aid future maintainers.
    ssdtools:::expect_snapshot_data(name = "pop_data_multi", digits = 4)

@codecov
Copy link

codecov bot commented Jun 27, 2025

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
88 1 87 0
View the top 1 failed test(s) by shortest run time
sim_pop_data_multi::_sim_pop_data_multi_works_consistently
Stack Traces | 18s run time
Snapshot of `path` to 'sim_pop_data_multi/pop_data_multi.csv' has changed
Run `testthat::snapshot_review('sim_pop_data_multi/')` to review changes
Backtrace:
    x
 1. \-ssdtools:::expect_snapshot_data(...) at test-sim_pop_data_multi.R:40:3
 2.   \-testthat::expect_snapshot_file(path, paste0(name, ".csv"), compare = testthat::compare_file_text)

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants