Merge main branch and fix workflow failures#486
Conversation
Co-authored-by: d-morrison <2474437+d-morrison@users.noreply.github.com>
d-morrison
left a comment
There was a problem hiding this comment.
fix the code issues found by the failing workflows
Co-authored-by: d-morrison <2474437+d-morrison@users.noreply.github.com>
Fixed all workflow failures: Linting issues: Replaced R CMD check issues:
Package loads successfully and all tests pass. (commit 4e6b489) |
Co-authored-by: d-morrison <2474437+d-morrison@users.noreply.github.com>
d-morrison
left a comment
There was a problem hiding this comment.
fix issues identified in latest workflow run (21191111690)
Co-authored-by: d-morrison <2474437+d-morrison@users.noreply.github.com>
Fixed partial argument matching issues in R/curve_app_ui.R - replaced all instances of |
Thank you for taking the time to submit a pull request!
To maximize the chances of acceptance:
-.testthat).For more information see Contributing.
Changes
Merged latest main branch into decay-curve-2 feature branch to incorporate upstream changes and fixed all resulting workflow failures.
Conflicts Resolved
mixtools(kept only in Suggests), removed unusedpkgload, added missingconfigdependencyanalyze_sims,antibody_decay_curve,compare_seroincidence,count_strata,curve_app,t1f,y1f) and imports (theme_bw,vars)theme_bwandvarsimportFrom statementsNote: Used merge instead of rebase due to force-push restrictions.
Workflow Fixes
After merging, addressed all CI/CD workflow failures:
stop()withcli::cli_abort()inR/autoplot.seroincidence.by.RandR/autoplot.seroincidence.Rto comply with package style guidelinesh2,renderPlot,renderTable,sliderInput) for curve_app functionality.datapronoun inR/curve_app_server.Rfor proper data masking of variables (mu_y,mu_b,y0,b0,t1) within tibble construction, following tidyverse guidelines instead ofutils::globalVariables()to eliminate R CMD check NOTEssliderInput()calls inR/curve_app_ui.Rby replacing abbreviated parametervalwith the full parameter namevalueto eliminate R CMD check warningsAll tests pass and package loads successfully.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.