hi david

.github/workflows/python-tests.yml

@@ -0,0 +1,26 @@
+name: Python package
+
+on: [push]
+
+jobs:
+  build:
+
+    runs-on: ubuntu-latest
+    strategy:
+      matrix:
+        python-version: ["3.10", "3.13"]
+
+    steps:
+      - uses: actions/checkout@v4
+      - name: Set up Python ${{ matrix.python-version }}
+        uses: actions/setup-python@v5
+        with:
+          python-version: ${{ matrix.python-version }}
+      - name: Install dependencies
+        # This case we are only updating pip, but you could add other dependencies if needed.
+        run: |
+          python -m pip install --upgrade pip
+          python -m pip install pytest
+      - name: Test with pytest
+        run: |
+          pytest

.python-version

@@ -0,0 +1 @@
+3.11

.vscode/settings.json

@@ -0,0 +1,7 @@
+{
+    "python.testing.pytestArgs": [
+        "."
+    ],
+    "python.testing.unittestEnabled": false,
+    "python.testing.pytestEnabled": true
+}

main.py

@@ -0,0 +1,6 @@
+def main():
+    print("Hello from time-tests!")
+
+
+if __name__ == "__main__":
+    main()

pyproject.toml

@@ -0,0 +1,12 @@
+[project]
+name = "time-tests"
+version = "0.1.0"
+description = "Add your description here"
+readme = "README.md"
+requires-python = ">=3.11"
+dependencies = []
+
+[dependency-groups]
+dev = [
+    "pytest>=8.4.1",
+]

test_times.py

@@ -0,0 +1,82 @@
+from times import time_range, compute_overlap_time, iss_passes 
+from pytest import raises
+from unittest.mock import patch
+import requests
+import mock
+import responses
+
+def test_short_large():
+    large = time_range("2010-01-12 10:00:00", "2010-01-12 12:00:00")
+    short = time_range("2010-01-12 10:30:00", "2010-01-12 10:45:00", 2, 60)
+    expected = [('2010-01-12 10:30:00', '2010-01-12 10:37:00'), ('2010-01-12 10:38:00', '2010-01-12 10:45:00')]
+    result = compute_overlap_time(short, large)
+    assert result == expected
+
+def test_large_short():
+    large = time_range("2010-01-12 10:00:00", "2010-01-12 12:00:00")
+    short = time_range("2010-01-12 10:30:00", "2010-01-12 10:45:00", 2, 60)
+    expected = [('2010-01-12 10:30:00', '2010-01-12 10:37:00'), ('2010-01-12 10:38:00', '2010-01-12 10:45:00')]
+    result = compute_overlap_time(large, short)
+    assert result == expected
+
+def test_no_overlap():
+    time_1 = time_range("2010-01-12 10:00:00", "2010-01-12 12:00:00")
+    time_2 = time_range("2010-01-12 13:00:00", "2010-01-12 14:00:00", 2, 60)
+    expected = []
+    result = compute_overlap_time(time_1, time_2)
+    assert result == expected
+
+def text_overlap():
+    time_1 = time_range("2010-01-12 10:00:00", "2010-01-12 14:35:00")
+    time_2 = time_range("2010-01-12 13:00:00", "2010-01-12 15:00:00")
+    expected = []
+    result = compute_overlap_time(time_1, time_2)
+    assert result == expected
+
+def test_gaps():
+    time_1 = time_range("2010-01-12 10:00:00", "2010-01-12 16:00:00", 2, 120*60)
+    time_2 = time_range("2010-01-12 10:00:00", "2010-01-12 16:00:00", 2, 60*60)
+    expected = [('2010-01-12 10:00:00', '2010-01-12 12:00:00'), ('2010-01-12 14:00:00', '2010-01-12 16:00:00')]
+    result = compute_overlap_time(time_1, time_2)
+    assert result == expected
+
+def test_startend():
+    time_1 = time_range("2010-01-12 10:00:00", "2010-01-12 12:00:00")
+    time_2 = time_range("2010-01-12 12:00:00", "2010-01-12 16:00:00", 2, 60)
+    expected = []
+    result = compute_overlap_time(time_1, time_2)
+    assert result == expected
+
+def test_endstart_error():
+    with raises(ValueError, match=r"Start time is after the end time."):
+        time_range("2010-01-12 13:00:00", "2010-01-12 12:00:00")
+
+def test_interval_error():
+    with raises(ValueError, match=r".* number of intervals is not a positive integer.*"):
+        time_range("2010-01-12 11:00:00", "2010-01-12 12:00:00", 1.2)
+
+def test_mock_iss():
+    response_obj = requests.models.Response()
+    response_obj.encoding = 'ascii'
+    response_obj._content = b'{"passes": [{"startUTC": 1750904990, "endUTC": 1750905545}]}'
+    with mock.patch('requests.get', new=mock.MagicMock(return_value=response_obj)) as mock_get:
+        response = iss_passes('mock_url')
+        assert response == [['2025-06-26 03:29:50', '2025-06-26 03:39:05']]
+
+@responses.activate
+def test_mock_iss_resp():
+    responses.add(
+        responses.GET,
+        'https://api.n2yo.com/rest/v1/satellite/visualpasses/25544/56/0/0/5/50&apiKey=33Q884-HFUV8K-SCS3LG-55CU',
+        json = {"passes": [{"startUTC": 1750904990, "endUTC": 1750905545}]},
+        status = 200
+    )
+    response = iss_passes('https://api.n2yo.com/rest/v1/satellite/visualpasses/25544/56/0/0/5/50&apiKey=33Q884-HFUV8K-SCS3LG-55CU')
+    assert response == [['2025-06-26 03:29:50', '2025-06-26 03:39:05']]
+
+# @patch.object(requests, 'get')
+# def test_mock_iss():
+#     response_obj = requests.models.Response()
+#     response_obj.encoding = 'ascii'
+#     response_obj._content = b'{"passes": [{"startUTC": 1750904990, "endUTC": 1750905545}]}'
+

times.py

@@ -1,9 +1,19 @@
 import datetime
+import requests
+import json
 
 
 def time_range(start_time, end_time, number_of_intervals=1, gap_between_intervals_s=0):
     start_time_s = datetime.datetime.strptime(start_time, "%Y-%m-%d %H:%M:%S")
     end_time_s = datetime.datetime.strptime(end_time, "%Y-%m-%d %H:%M:%S")
+    if start_time_s > end_time_s:
+        raise ValueError("Start time is after the end time.")
+    # try: 
+    #     number_of_intervals = int(number_of_intervals)
+    # except ValueError:
+    #     raise ValueError('The number of intervals is not a number.')
+    if type(number_of_intervals) is not int and number_of_intervals > 0:
+        raise ValueError(f"The number of intervals is not a positive integer. You put in {number_of_intervals}!!!")
     d = (end_time_s - start_time_s).total_seconds() / number_of_intervals + gap_between_intervals_s * (1 / number_of_intervals - 1)
     sec_range = [(start_time_s + datetime.timedelta(seconds=i * d + i * gap_between_intervals_s),
                   start_time_s + datetime.timedelta(seconds=(i + 1) * d + i * gap_between_intervals_s))
@@ -17,10 +27,26 @@ def compute_overlap_time(range1, range2):
         for start2, end2 in range2:
             low = max(start1, start2)
             high = min(end1, end2)
-            overlap_time.append((low, high))
+            if high > low:
+                overlap_time.append((low, high))
     return overlap_time
 
+def iss_passes(url):
+    response=requests.get(url)
+    #response_text=json.loads(response.text)
+    response_text = response.json()
+    passes=response_text['passes']
+
+    times=[]
+    for p in passes:
+        start_unix, end_unix = p['startUTC'], p['endUTC']
+        start, end = datetime.datetime.fromtimestamp(start_unix), datetime.datetime.fromtimestamp(end_unix)
+        times.append([start.strftime("%Y-%m-%d %H:%M:%S"),end.strftime("%Y-%m-%d %H:%M:%S")])
+    return times
+
 if __name__ == "__main__":
-    large = time_range("2010-01-12 10:00:00", "2010-01-12 12:00:00")
-    short = time_range("2010-01-12 10:30:00", "2010-01-12 10:45:00", 2, 60)
-    print(compute_overlap_time(large, short))
+    # large = time_range("2010-01-12 10:00:00", "2010-01-12 12:00:00")
+    # short = time_range("2010-01-12 10:30:00", "2010-01-12 10:45:00", 2, 60)
+    # print(compute_overlap_time(large, short))
+    print(iss_passes('https://api.n2yo.com/rest/v1/satellite/visualpasses/25544/56/0/0/5/50&apiKey=33Q884-HFUV8K-SCS3LG-55CU'))
+