Written unit tests for interval comparison#17
Open
greneus wants to merge 10 commits intoUCL-COMP0233-2022-2023:mainfrom
Open
Written unit tests for interval comparison#17greneus wants to merge 10 commits intoUCL-COMP0233-2022-2023:mainfrom
greneus wants to merge 10 commits intoUCL-COMP0233-2022-2023:mainfrom
Conversation
Author
|
Answers UCL-MPHY0021-21-22/RSE-Classwork#16 The code is buggy with negative length intervals showing up in results and it's not robust against zero length intervals (ie. when two intervals share edges) -- hence my unit tests fail. |
Author
added 7 commits
November 3, 2022 11:00
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Answers UCL-MPHY0021-21-22/RSE-Classwork#16
There is a subtlety in the interval comparison, namely that an interval of 0 seconds (ie. start == end) is also counted as an overlap.