Adding answers to week 3 homework assignment.#58
Open
L-Amos wants to merge 15 commits intoUCL-COMP0233-24-25:mainfrom
Open
Adding answers to week 3 homework assignment.#58L-Amos wants to merge 15 commits intoUCL-COMP0233-24-25:mainfrom
L-Amos wants to merge 15 commits intoUCL-COMP0233-24-25:mainfrom
Conversation
…culation of mean connections.
gpwhs
approved these changes
Oct 17, 2024
gpwhs
left a comment
gpwhs
left a comment
There was a problem hiding this comment.
generally good, i'd suggest:
- docstrings on functions
- raise exceptions like ValueError instead of printing
| max_age_with_friends = np.max([person["age"] for person in my_group.values() if "friend" in person["connections"].values()]) | ||
| print(max_age_with_friends) | ||
|
|
||
| homework() |
There was a problem hiding this comment.
this will run whenever you import group.py i believe, probably don't want to run this here. Use if name == "main":
| if job and not isinstance(job, str): | ||
| print("Job must be string") | ||
| return | ||
| if relations and not isinstance(relations, dict): |
There was a problem hiding this comment.
good checks, happy w this, maybe you can check if the keys in relations exist but 🤷
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Answers UCL-COMP0233-24-25/RSE-Classwork#7.