Unfinished solution at end of breakout room#13
Open
will43w wants to merge 3 commits intoUCL-MPHY0021-21-22:mainfrom
Open
Unfinished solution at end of breakout room#13will43w wants to merge 3 commits intoUCL-MPHY0021-21-22:mainfrom
will43w wants to merge 3 commits intoUCL-MPHY0021-21-22:mainfrom
Conversation
|
Thanks for uploading Will! |
mrmoodyd
reviewed
Oct 21, 2021
mrmoodyd
left a comment
mrmoodyd
left a comment
There was a problem hiding this comment.
Interesting and more flexible choice to make the 'Group' a class as opposed to a dictionary.
mrmoodyd
reviewed
Oct 21, 2021
group.py
Outdated
| self.relationships[relationship] = name | ||
|
|
||
|
|
||
| YLTWH = Group() |
There was a problem hiding this comment.
Assuming this is unfinished, but group is defined but not used.
Trying to practice by attempting homework UCL-MPHY0021-21-22#12 group.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.