Open
Conversation
stefpiatek
reviewed
Oct 22, 2021
Collaborator
stefpiatek
left a comment
stefpiatek
left a comment
There was a problem hiding this comment.
Different way to model the relationships, added in some suggestions/comments
Comment on lines
+8
to
+12
| "friend": "zalika", | ||
| "partner": "john", | ||
| "cousin": "", | ||
| "landlord": "", | ||
| "tenant": "" |
Collaborator
There was a problem hiding this comment.
ah interesting, instead of a nested relationships you've got each one as an attribute. It works but I guess you end up having a lot of empty values!
| ages = [my_group[person]["age"] for person in my_group] | ||
|
|
||
| # Assuming relations means has partner or cousin | ||
| partners = ["partner" for person in my_group if my_group[person]["partner"]] |
Collaborator
There was a problem hiding this comment.
could you simplify this to
Suggested change
| partners = ["partner" for person in my_group if my_group[person]["partner"]] | |
| partners = ["partner" for person in my_group if person["partner"]] |
Comment on lines
+47
to
+51
| partners = ["partner" for person in my_group if my_group[person]["partner"]] | ||
| cousins = ["cousin" for person in my_group if my_group[person]["cousin"]] | ||
|
|
||
| relations = [] | ||
| relations.extend(partners + cousins) |
Collaborator
There was a problem hiding this comment.
Also could you do it all in one expression?
Suggested change
| partners = ["partner" for person in my_group if my_group[person]["partner"]] | |
| cousins = ["cousin" for person in my_group if my_group[person]["cousin"]] | |
| relations = [] | |
| relations.extend(partners + cousins) | |
| partners = ["partner" for person in my_group if my_group[person]["partner"]] | |
| cousins = ["cousin" for person in my_group if my_group[person]["cousin"]] | |
| relations = [] | |
| relations.extend(partners + cousins) |
| has_friends = [my_group[person]["age"] for person in my_group if my_group[person]["friend"]] | ||
|
|
||
| # Print results | ||
| print(f"The maximum age in our group is: {max(ages)}") |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I hope this works!
Answers UCL-MPHY0021-21-22/RSE-Classwork#12