Arosi solo attempt #23
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
| @@ -1,5 +1,60 @@ | ||||||
| group = { | ||||||
| "Jill": { | ||||||
| "age": 26, | ||||||
| "job": "biologist", | ||||||
| "relations": { | ||||||
| "Zalika": "friend", | ||||||
| "John": "partner" | ||||||
| } | ||||||
| }, | ||||||
| "Zalika": { | ||||||
| "age": 28, | ||||||
| "job": "artist", | ||||||
| "relations": { | ||||||
| "Jill": "friend" | ||||||
| } | ||||||
| }, | ||||||
| "John": { | ||||||
| "age": 27, | ||||||
| "job": "writer", | ||||||
| "relations": { | ||||||
| "Jill": "partner" | ||||||
| } | ||||||
| }, | ||||||
| "NewGuyNoFriends": { | ||||||
| "age": 150, | ||||||
| "job": "student", | ||||||
| "relations": { | ||||||
| } | ||||||
| }, | ||||||
| "Nash": { | ||||||
| "age": 34, | ||||||
| "job": "chef", | ||||||
| "relations": { | ||||||
| "John": "cousin", | ||||||
| "Zalika": "landlord" | ||||||
| } | ||||||
| } | ||||||
| } | ||||||
|
|
||||||
| # the maximum age of people in the group | ||||||
| max_age = max([group.get(personName).get("age") for personName in group.keys()]) | ||||||
|
Collaborator
There was a problem hiding this comment. You could simplify the base of your list comprehension a little bit by using the values directly
Suggested change
|
||||||
| print("oldest person is", max_age) | ||||||
|
|
||||||
| # the average (mean) number of relations among members of the group | ||||||
| import numpy as np | ||||||
|
Collaborator
There was a problem hiding this comment. some style feedback: you should have all import statements at the start of your script |
||||||
| relationships_dict_list = [group.get(personName).get("relations") for personName in group.keys()] | ||||||
| mean_relations = np.mean([len(personalRelations.keys()) for personalRelations in relationships_dict_list]) | ||||||
| print("mean number of relations is", mean_relations) | ||||||
|
|
||||||
| # the maximum age of people in the group that have at least one relation | ||||||
| max_non_relationless = max([group.get(personName).get("age") for personName in group.keys() if len(group.get(personName).get("relations")) != 0]) | ||||||
|
Collaborator
There was a problem hiding this comment. could also use the inherent "falsyness" of an empty dictionary
Suggested change
|
||||||
| print("oldest person with at least one relation of any type is", max_non_relationless, "years old") | ||||||
|
|
||||||
| # [more advanced] the maximum age of people in the group that have at least one friend | ||||||
| max_nonfriendless = max([group.get(personName).get("age") for personName in group.keys() if "friend" in list(group.get(personName).get("relations").values())]) | ||||||
| print("oldest person with a relation of type friend is", max_nonfriendless, "years old") | ||||||
|
|
||||||
|
|
||||||
|
|
||||||
|
|
||||||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
poor guy 😢