Analysis: using functions instead#4
Open
scerbo-robert wants to merge 1 commit intoUCL-MPHY0021-21-22:mainfrom
Open
Analysis: using functions instead#4scerbo-robert wants to merge 1 commit intoUCL-MPHY0021-21-22:mainfrom
scerbo-robert wants to merge 1 commit intoUCL-MPHY0021-21-22:mainfrom
Conversation
ageorgou
reviewed
Dec 15, 2021
Contributor
ageorgou
left a comment
ageorgou
left a comment
There was a problem hiding this comment.
You were right to identify that the two files can be read with the same function, to eliminate that repetition. Could you extend that function so that it also reads the weight file, or do you think that would be too different and end up confusing?
When changing code, avoid leaving in the old version, as it can quickly become outdated and misleading. Remember that, with git, you can revisit old versions of the code.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.