Boids: Split into multiple functions & define variables#5
Open
matthewtam17 wants to merge 2 commits intoUCL-MPHY0021-21-22:mainfrom
Open
Boids: Split into multiple functions & define variables#5matthewtam17 wants to merge 2 commits intoUCL-MPHY0021-21-22:mainfrom
matthewtam17 wants to merge 2 commits intoUCL-MPHY0021-21-22:mainfrom
Conversation
Author
|
Group 24 |
ageorgou
reviewed
Dec 15, 2021
Contributor
ageorgou
left a comment
There was a problem hiding this comment.
Good way of breaking up the program and explain the different parts. I like that you have converted the comments into docstrings. Try consistently eaving 1-2 empty lines between functions (the style guide suggests 2); it may seem trivial, but it does help with readability.
Very very minor point: max_iteration makes me think you are doing the same thing multiple times, whereas here you are working through the list of values. Perhaps number_boids or something like that would be a more intuitive name.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Boids: Refactoring - split into multiple functions, convert some magic numbers into defined variables.