Skip to content

Boids: Split into multiple functions & define variables#5

Open
matthewtam17 wants to merge 2 commits intoUCL-MPHY0021-21-22:mainfrom
matthewtam17:main
Open

Boids: Split into multiple functions & define variables#5
matthewtam17 wants to merge 2 commits intoUCL-MPHY0021-21-22:mainfrom
matthewtam17:main

Conversation

@matthewtam17
Copy link

Boids: Refactoring - split into multiple functions, convert some magic numbers into defined variables.

@matthewtam17
Copy link
Author

Group 24

Copy link
Contributor

@ageorgou ageorgou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good way of breaking up the program and explain the different parts. I like that you have converted the comments into docstrings. Try consistently eaving 1-2 empty lines between functions (the style guide suggests 2); it may seem trivial, but it does help with readability.

Very very minor point: max_iteration makes me think you are doing the same thing multiple times, whereas here you are working through the list of values. Perhaps number_boids or something like that would be a more intuitive name.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants