SWIG: expose more LOR and listmode classes#1288
Merged
KrisThielemans merged 6 commits intoUCL:masterfrom Nov 16, 2023
Merged
Conversation
- add LORAs2Points etc - added .h file to work-around SWIG bug with private typedef self_type - removed some old #ifdefs in the .h file To do this cleanly, move lines from stir.i to separate stir_LOR.i
To do this cleanly, move lines from stir.i to separate stir_listmode.i
KrisThielemans
force-pushed
the
SWIGlistmode
branch
from
b225bdb to
49fbebf
Compare
…constructors The first was not implemented, and would need an extra radius argument. The others called it, but also would have needed a radius
KrisThielemans
force-pushed
the
SWIGlistmode
branch
from
49fbebf to
4a4f334
Compare
- needed to import ListEvent and ListTime BEFORE ListRecord (SWIG BUG) - add CListModeData, just in case - added example and basic test
explicitly use stir/listmode. It doesn't seem to matter, but is cleaner.
ghost
approved these changes
Nov 16, 2023
ghost
left a comment
ghost
left a comment
There was a problem hiding this comment.
Looks good and great work with the test and demo
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FloatLORtoLORin SWIGListRecordetc.Currently python3 crashes when I
import stir, but that might be a local problem.