TOF fixes, mostly for GE HDF5 list-mode#1324
Merged
KrisThielemans merged 27 commits intoUCL:masterfrom Jan 12, 2024
Merged
Conversation
When parsing Interfile headers for projection data and the <tt>originating system</tt> is not recognised, the previous version of STIR tried to guess the scanner based on the number of views or rings. This was using very old scanners though, and could lead to confusion. These guesses have now been removed.
follow same strategy as for other keywords
this was already fine, but setting the TOF mashing to 0 explicitly makes it clearer
checked info from RDF file
also made sure we have to call set_up() again after changing TOF keywords
use ProjDataInfo member instead
use existing read_dataset_int32
use proj_data_info instead
Interfile headers now use use the following keywords:
number of radionuclides := 1
radionuclide name[1] := ...
radionuclide halflife (sec)[1] := ...
radionuclide branching factor[1] := ...
Previous versions of STIR used `isotope name`. This is still recognised
if `radionuclide name[1]` is not present. Note that
neither versions are confirming to the (very old) Interfile 4.0 proposal.
Previous code was leading to a stack corruption in debug mode, although I don't understand why. In any case, this is more correct.
Images are now fine.
Default (i.e. unset) half-life is 0, so the test thought the half-life was set, then causing an error thrown.
KrisThielemans
force-pushed
the
GEfixes
branch
from
6f55f95 to
4653741
Compare
Collaborator
Author
|
I'll merge this. things to do on sinograms and the example, but at least major things are fixed, and some of the utilities are useful. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With this PR, TOF reconstructions of the GE Signa PET/MR of the VQC phantom are fine, addressing most of #1309 (but not yet keeping the TOF dimension when reading projection data from RDF9).
In addition, it fixes #1323 and adds some functionality to
list_lm_eventsto list bin info, and some other minor stuff.