Rebuilt plot_sinogram_profiles.py for 4D tof data#1370
Rebuilt plot_sinogram_profiles.py for 4D tof data#1370KrisThielemans merged 7 commits intoUCL:masterfrom
plot_sinogram_profiles.py for 4D tof data#1370Conversation
robbietuk
left a comment
There was a problem hiding this comment.
A few usage observations
KrisThielemans
left a comment
There was a problem hiding this comment.
I'm happy with this and would be ok to merge (after an update to release_6.1.htm)
|
pytest fails with Could be solved by adding it to the pythonpath first (would need to be done both for GHA and AppVeyor). Alternatively, we do it better via #1392 |
|
@robbietuk want to finish this one? I think only needs
I'm hoping to release 6.3 soon, as it has a major bug fix. We could leave this for later if you have no time now. |
|
@robbietuk hopefully the pytest work-around is fine. Can you please add something to |
923afba to
ed5a251
Compare
KrisThielemans
left a comment
There was a problem hiding this comment.
This should be fine now. ok to squash merge?
|
GHA is fine but AppVeyor fails I think this is because python 3.8 is too old for this type of hinting. |
|
I'd prefer to support python 3.8 and 3.9 for a bit longer. https://typing.readthedocs.io/en/latest/guides/modernizing.html seems to say |
|
Feel free to do anything to merge this. Thank you for getting the pytesting working. I hope my Union[] fix resolves the Appveyor issue |
try to resolve use of | for python 3.8
526ffae to
217c3d9
Compare
|
|
|
success! (at least for 3.8) |
Changes in this pull request
Built
plot_projdata_profiles.pyto replaceplot_sinogram_profiles.py. This allows for TOF data to be handled. I added significant error handling and what I hope is a better user experience. It does break backwards compatabity.I need to add a the ability to read v6.0 STIR projection data.
Testing performed
Include a pytest (commented out)
Related issues
#1363
Checklist before requesting a review
documentation/release_XXX.mdhas been updated with any functionality change (if applicable)